Skip to content

refactor: Replace roadrunner by php's gRPC server #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Replace roadrunner by php's gRPC server #728

wants to merge 2 commits into from

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented May 17, 2025 •
edited
Loading

  • gRPC example: Replace roadrunner (gRPC server written in golang) by php built in server
    • PHP can be gRPC server, from 4 years ago, but somehow the document is not updated, so I didn't know this ability
    • Probably because PHP is not suitable for this job. But at least we can do it for demo purpose, without the need of installing extra tool
  • Pre-generate protobuf library so we don't need to install protoc and grpc_php_plugin tools, then generate these files again and again in CI

@tienvx tienvx force-pushed the grpc-php-server branch 4 times, most recently from a4f950e to de1798a Compare May 17, 2025 10:23
@coveralls
Copy link

coveralls commented May 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15095224263

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.313%
Totals Coverage Status
Change from base Build 14472558905: 0.0%
Covered Lines: 2560
Relevant Lines: 2658
💛 - Coveralls

@tienvx tienvx force-pushed the grpc-php-server branch 5 times, most recently from ee411b5 to ea39ac6 Compare May 17, 2025 12:44
@tienvx tienvx force-pushed the grpc-php-server branch 2 times, most recently from d982caf to ee1142b Compare May 17, 2025 16:28
@tienvx tienvx marked this pull request as ready for review May 17, 2025 17:00
@tienvx tienvx force-pushed the grpc-php-server branch from ee1142b to 9704880 Compare May 17, 2025 18:02
@tienvx tienvx force-pushed the grpc-php-server branch from 9704880 to a7fafa9 Compare May 18, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @coveralls