feat: add --retries / PACT_BROKER_HTTP_RETRIES to pact_verifier_cli - #534
Merged
Conversation
JP-Ellis
force-pushed
the
feat/verifier-cli-retries
branch
from
May 26, 2026 07:20
1b58c1a to
3c0d4e8
Compare
Contributor
Such a tiny change for a version bump? |
Member
Author
|
The main thing here is a new flag, hence the new minor version. Technically, there's a breaking change (the typo fix is part of the public interface...). Up to you what version bump you prefer. I can fix up this PR easily. |
Contributor
|
Ok, I've reset the version on the CLI but kept the version bump for the verifier crate. |
Contributor
|
There is a failing test, as the error text has now changed: |
Exposes broker HTTP retry count as --retries (env: PACT_BROKER_HTTP_RETRIES, default: 8) in pact_verifier_cli, matching the flag in pact-broker-cli. The retry count is threaded through VerificationOptions.broker_request_retries into the HALClient used for all broker calls: pact fetching (both legacy and dynamic) and publishing verification results. pact_verifier and cli bumped to 1.4.0 Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
feat/verifier-cli-retries
branch
from
May 27, 2026 05:22
2709b4c to
27a6872
Compare
Member
Author
|
Couldn't be bothered dealing with the merge commit when I rebased... so it clobbered the git history. Anyway, error is fixed, kept the minor version bump for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes broker HTTP retry count as --retries (env: PACT_BROKER_HTTP_RETRIES,
default: 8) in pact_verifier_cli, matching the flag in pact-broker-cli.
The retry count is threaded through VerificationOptions.broker_request_retries into the HALClient used for all broker calls: pact fetching (both legacy and dynamic) and publishing verification results.
pact_verifier and cli bumped to 1.4.0