fix: retry logic - #83
Merged
Merged
Conversation
Adjust the retry logic so that it: - Retries on 5XX server errors, 429 Too Many Requests, and 408 Request Timeout - In the case of a 429, also parse the `Retry-After` header (if present) for the delay - Tweak the exponential retry delay from millisecond decades starting from 1ms, to powers of 2 starting from 0.5s. It is unlikely that a 1ms delay will resolve the issue, but also going from 1s to 10s to 100s is quite a steep increase. Also took the opportunity to upgrade reqwest to 0.13. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
marked this pull request as draft
May 26, 2026 07:36
Signed-off-by: JP-Ellis <josh@jpellis.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the retry logic so that it:
Retry-Afterheader (if present) for the delayAlso took the opportunity to upgrade reqwest to 0.13.
Note
This pulls in the
pact_verifierand relies on the changes in pact-foundation/pact-reference#533 being published to crates.io.