fix: move #[global_allocator] from lib to binary crate - #85
Closed
JP-Ellis wants to merge 1 commit into
Closed
Conversation
When pact-stub-server is used as a library (e.g. embedded in pact-cli), the #[global_allocator] declaration in lib.rs imposed mimalloc as the allocator for the entire host binary. This caused mimalloc to abort() — with no Rust panic message — when OpenTelemetry was active in the host process, because OTEL's internal heap activity violated a mimalloc invariant. Moving the declaration to bin/pact-stub-server.rs means: - The standalone pact-stub-server binary still uses mimalloc (no change in performance characteristics) - Library consumers get the system/default allocator and are not affected Assisted-by: Claude Code:claude-sonnet-4-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pact-stub-server is used as a library (e.g. embedded in pact-cli), the
#[global_allocator]declaration inlib.rsimposed mimalloc as the allocator for the entire host binary. This caused mimalloc toabort()with no Rust panic message when OpenTelemetry was active in the host process, because OTEL's internal heap activity violated a mimalloc invariant.Moving the declaration to bin/pact-stub-server.rs means: