Skip to content

Conversation

@mcancade
Copy link
Contributor

No description provided.

Copy link
Member

@agiliopadua agiliopadua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to keep the functionality of PDB with hex for large-ish systems?


def hexiflarge(i, ndig):
"""
Convert number to hex starting with A000... if more than n digits.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clear to leave it as A000

i = i - declim + hexlim
return f'{i:X}'

def intfromhexiflarge(a):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is needed


# f.write('\n')

def writeopenmm(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not elegant.
If the omm.py is immutable then we can supply it as a file in some directory with fftool.
In python the way to write chunks of text is as a multiline string """..."""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is lost when using the multiline string notation. I'm not sure that it is clearer.
Supply a standard omm.py file with fftool is also a good option. For me, the workflow seems simpler if fftool writes the input files (such for LAMMPS); but for sure it depends on the user.

c4 = -4 * dit.par[3] + eps
c5 = 0.0
dimpr = ET.SubElement(torsionforce, 'Improper')
# in OpenMM atom 1 (not 3) is the central atom of an improper dihedral
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this?


ET.indent(root, space=' ')
ftree.write('field.xml')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you think we should suppress the ability to handle pdf files with large-ish systems. Shouldn't we leave this for vmd for example?


ET.indent(root, space=' ')
ftree.write('field.xml')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above (line 2250)

help = 'connect bonds across periodic boundaries in '\
'x, xy, xyz, etc. (default: none)')
parser.add_argument('-x', '--xml', action = 'store_true',
help = 'create OpenMM files .xml .pdb or .mmcif '\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep mmcif?

.format(zfile, spec[i].name, spec[i].nmol, spec[i].ffile,
len(spec[i].atom), len(spec[i].bond), spec[i].topol,
spec[i].charge()))
natom += spec[i].nmol * len(spec[i].atom)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using this anymore?

@mcancade mcancade closed this Mar 6, 2025
@mcancade mcancade reopened this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants