-
Notifications
You must be signed in to change notification settings - Fork 1
page #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
page #1
Conversation
const tarotCards = { | ||
"Major Arcana": [ | ||
"0 - The Fool", | ||
"1 - The Magician", | ||
"2 - The High Priestess", | ||
"3 - The Empress", | ||
"4 - The Emperor", | ||
"5 - The Hierophant", | ||
"6 - The Lovers", | ||
"7 - The Chariot", | ||
"8 - Strength", | ||
"9 - The Hermit", | ||
"10 - Wheel of Fortune", | ||
"11 - Justice", | ||
"12 - The Hanged Man", | ||
"13 - Death", | ||
"14 - Temperance", | ||
"15 - The Devil", | ||
"16 - The Tower", | ||
"17 - The Star", | ||
"18 - The Moon", | ||
"19 - The Sun", | ||
"20 - Judgment", | ||
"21 - The World" | ||
], | ||
"WANDS": [ | ||
"Ace of Wands", | ||
"Two of Wands", | ||
"Three of Wands", | ||
"Four of Wands", | ||
"Five of Wands", | ||
"Six of Wands", | ||
"Seven of Wands", | ||
"Eight of Wands", | ||
"Nine of Wands", | ||
"Ten of Wands", | ||
"Page of Wands", | ||
"Knight of Wands", | ||
"Queen of Wands", | ||
"King of Wands" | ||
], | ||
"CUPS": [ | ||
"Ace of Cups", | ||
"Two of Cups", | ||
"Three of Cups", | ||
"Four of Cups", | ||
"Five of Cups", | ||
"Six of Cups", | ||
"Seven of Cups", | ||
"Eight of Cups", | ||
"Nine of Cups", | ||
"Ten of Cups", | ||
"Page of Cups", | ||
"Knight of Cups", | ||
"Queen of Cups", | ||
"King of Cups" | ||
], | ||
"SWORDS": [ | ||
"Ace of Swords", | ||
"Two of Swords", | ||
"Three of Swords", | ||
"Four of Swords", | ||
"Five of Swords", | ||
"Six of Swords", | ||
"Seven of Swords", | ||
"Eight of Swords", | ||
"Nine of Swords", | ||
"Ten of Swords", | ||
"Page of Swords", | ||
"Knight of Swords", | ||
"Queen of Swords", | ||
"King of Swords" | ||
], | ||
"PENTACLES": [ | ||
"Ace of Pentacles", | ||
"Two of Pentacles", | ||
"Three of Pentacles", | ||
"Four of Pentacles", | ||
"Five of Pentacles", | ||
"Six of Pentacles", | ||
"Seven of Pentacles", | ||
"Eight of Pentacles", | ||
"Nine of Pentacles", | ||
"Ten of Pentacles", | ||
"Page of Pentacles", | ||
"Knight of Pentacles", | ||
"Queen of Pentacles", | ||
"King of Pentacles" | ||
] | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nää saattas olla sellasta tietoa mitä tarvis muuallakin? Saisko nää esim. johonki omaan tiedostoon mihin vois kerää konstantteja tai saisko nää siel json filusta missä ois kaikki ne muutkin tiedot ni ei tarvis toistaa?
Edit: Tää systeemi vissii pyörii atm pelkästään ton constin avulla? Sanoisin et tää kantsii jo nyt alkuvaiheessa kirjottaa uusiks silleen, että se käyttää sitä lopullista systeemiä oliko se nyt sit se json filu missä kaikki kortti tiedot tms.
--> sit muokkaa noi funktiot käyttämään sellasta formaattia et saa kaikki kortin tiedot vaiks sillä kortin id:llä niin ei tarvi sit miljoonaa omaa muuttujaa niille --> samalla sais korjattua ton kortti indeksi ongelman ku vaan kategorian id muuttuu, mutta kortille ei tarvi tehä mitään muutaku et se lataa uudet tiedot
<div className="page-of-tarot-bar"> | ||
<h1>Page Of Tarot</h1> | ||
</div> | ||
<button className="sidebar-toggle" onClick={toggleSidebar}> | ||
{isSidebarOpen ? '☰' : '☰'} | ||
</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanoinkin jo Hertalle 121 et vois tehä headerille yms omat komponentit ja sit importtaa ne kun tarvitaan.
<div className={`sidebar ${isSidebarOpen ? 'open' : ''}`}> | ||
<div className="sidebar-content"> | ||
{Object.entries(tarotCards).map(([category, cards], categoryIndex) => ( | ||
<div key={categoryIndex}> | ||
<h3>{category}</h3> | ||
<ul> | ||
{cards.map((card, index) => ( | ||
<li key={index}> | ||
<button className="button" onClick={() => handleCardClick(card)}> | ||
{card} | ||
</button> | ||
</li> | ||
))} | ||
</ul> | ||
</div> | ||
))} | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Myös tää vois olla oma komponentti
setCurrentCardIndex(0); // Nollaa kortti-indeksi kategorian vaihdon yhteydessä | ||
setSelectedCard(null); // Tyhjentää valitun kortin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oliks näille joku tarkotus?
setCurrentCardIndex(0);
Tää asettaa kortin aina siihen kategorian ekaan korttiin? Eiks tää sit oo syy tolle bugille et se on väärässä kortissa sit vaihossa(?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kirjotin tonne ylempään kommenttiin tosta tietojen hakemisesta/käytöstä
.tervetuloa { | ||
font-size: 20px; | ||
font-family: 'Courier New', Courier, monospace; | ||
font-weight: bold; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fonttikoko: 1.25rem
Tän vois nimetä uudestaan --> ehkä miettii oisko se joku tyyli mitä voi käyttää muuallakin vai onks se just tätä varten mieluiten varmaan kaikki nimet enkuks niin pysyy yhtenäisenä :)
justify-content: center; | ||
align-items: center; | ||
text-align: center; | ||
font-size: 14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.875rem
top: 0; | ||
left: 0; | ||
text-align: center; | ||
font-size: 24px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1,5rem
} | ||
|
||
.arrow-button { | ||
font-size: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.75rem
--> vois muuttaa nää tohon ja et se vastaa 44px niin on standardi
export const metadata: Metadata = { | ||
title: "Create Next App", | ||
description: "Generated by create next app", | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ei ehkä just akuutti, mut nää vois muuttaa jo nyt niin ei pääse unohtumaan
# Page of Tarot | ||
## Build | ||
`npm install` | ||
This is a [Next.js](https://nextjs.org/) project bootstrapped with [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mahtaako tarkotuksella vai vahingossa olla tää og README?
Tässä branchissa oli tosiaan toi app nyt kaks kertaa, olikohan se tarkotus olla tuolla sourcessa? |
bugi kortin vaihdossa