Skip to content

Add styles for tasklist#83

Draft
davorpa wants to merge 1 commit into
pages-themes:masterfrom
davorpa:feature/styles-for-tasklist
Draft

Add styles for tasklist#83
davorpa wants to merge 1 commit into
pages-themes:masterfrom
davorpa:feature/styles-for-tasklist

Conversation

@davorpa

@davorpa davorpa commented Aug 31, 2021

Copy link
Copy Markdown

Generate styles for tasklist preserving theme colors

image
to
image

A complete implement for #75. Resolves #75

Preview a demo at https://davorpa.github.io/github-pages-themes-hacker/#what-about-task-lists

@davorpa davorpa marked this pull request as ready for review August 31, 2021 03:25
@davorpa

davorpa commented Aug 31, 2021

Copy link
Copy Markdown
Author

@parkr could you approval me to workflow?

It works like a charm and my build pass. See davorpa#5

@jimhall

jimhall commented Aug 31, 2021

Copy link
Copy Markdown

This is a great idea and simple implementation.

@parkr parkr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, though it would be great to test this on all major browsers.

@davorpa

davorpa commented Oct 13, 2021

Copy link
Copy Markdown
Author

This LGTM, though it would be great to test this on all major browsers.

  • What is the pointcut?

Some feedback in my scope.

Windows - Chrome

As seen as in PR description. I dont remember the version I took the snapshot with 😟. Now I have 94.0.4606.81 and it looks the same.

Windows - Edge 94.0.992.38

image

Windows - IE 11.0.9600.19596 or minor

image

Need fix. Maybe due to missing ms- vendor property Not supported 😢

Here some pointcut CSS hacks: https://browserstrangeness.bitbucket.io/css_hacks.html

@jimhall

jimhall commented Oct 13, 2021

Copy link
Copy Markdown

Still better than what we started with!

@parkr

parkr commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

I believe Microsoft is trying to migrate to Edge and away from Internet Explorer, so this shouldn't be a huge issue.

Safari, Chrome, and Firefox on Mac look good to me.

:shipit:

@parkr

parkr commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

(I left GitHub and can't merge this, but I give it my approval!)

@davorpa

davorpa commented Oct 13, 2021

Copy link
Copy Markdown
Author

Still better than what we started with!

I have in my backlog apply some IE11- hack to remove this decoration. I'll also try to increase checkboxes size to be pixel perfect more or less.

@rabooli

rabooli commented Oct 13, 2021 via email

Copy link
Copy Markdown

@stale

stale Bot commented Jan 9, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix label Jan 9, 2022
@jimhall

jimhall commented Jan 9, 2022

Copy link
Copy Markdown

Would prefer this kept open.

@stale stale Bot removed the wontfix label Jan 9, 2022
@davorpa

This comment has been minimized.

@davorpa davorpa marked this pull request as draft January 9, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper way to override task-list display

5 participants