Change background gradient in jekyll-theme-midnight.scss to background-image property #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome! Congrats on your first pull request to the Midnight theme. If you haven't already, please be sure to check out the contributing guidelines. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a mouse wheel or two-finger scrolling to scroll up past the top of a website, you can see the background of a site past the main window. Usually you just see the
backgroundcolor from the page body there. In the current version that overlap is white because there are twobackgroundproperties specified in_sass/jekyll-theme-midnight.scss. Currently, the lastbackgroundproperty with the linear gradient overrides the first. Switching that one tobackground-imageas described here makes it so that the firstbackgroundproperty still applies to that overlap space and provides a bit cleaner transition, while the linear gradient is preserved.Before and after screenshots in Chrome are attached:
After
Before
