Add conditional for "View On GitHub" button

[sindastra]

Add conditional for "View On GitHub" button
Also added conditional for the <ul> or else if both are disabled it would show an empty box

[welcome]

Welcome! Congrats on your first pull request to the Modernist theme. If you haven't already, please be sure to check out the contributing guidelines.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sindastra]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Well, bump?

[parkr]

Hey @sindastra! Thanks for your patience. Could you tell me a bit more about why you want this to be conditional and not show for user pages?

[sindastra]

Hi @parkr!

If you take a quick look at the code you'll see that it's basically improved logic: If neither is there to show, then don't show anything.

With the original logic, if neither is there to show, it will still display a box, however it will be empty.

[davorpa]

LGTM 👍

Is more or less like I did in hacker theme pages-themes/hacker#81

[marschr]

Since this is still open, for the modernist theme I had to make a hacky assets/css/styles.scss file and add the following:

---
---

@import "{{ site.theme }}";

header > ul {
  display: none !important;
}

footer {
  display: none !important;
}

inspired from: pages-themes/cayman#79 (comment)