Skip to content

Comments

Fix variable name in readme#89

Merged
tsusdere merged 2 commits intopages-themes:masterfrom
kabilar:master
Aug 22, 2025
Merged

Fix variable name in readme#89
tsusdere merged 2 commits intopages-themes:masterfrom
kabilar:master

Conversation

@kabilar
Copy link
Contributor

@kabilar kabilar commented Dec 8, 2023

Description and changes

  • Based on the example discussed, it appears that the variable name should change from site.github.url to site.github.zip_url.

@welcome
Copy link

welcome bot commented Dec 8, 2023

Welcome! Congrats on your first pull request to the Slate theme. If you haven't already, please be sure to check out the contributing guidelines.

@kabilar
Copy link
Contributor Author

kabilar commented Aug 1, 2025

Hi @tsusdere @parkr @benbalter, I am just following up to see if you would be able to review/merge this pull request? Thank you.

@parkr
Copy link
Contributor

parkr commented Aug 1, 2025

Might need a rebase. I don't think I have merge permissions anymore.

@kabilar
Copy link
Contributor Author

kabilar commented Aug 1, 2025

Thank you, @parkr. I just rebased.

@tsusdere
Copy link
Contributor

👋🏻 Thank you for contributing! Should be good to merge when you decide to do so @kabilar

@kabilar
Copy link
Contributor Author

kabilar commented Aug 22, 2025

Thank you @tsusdere. Looks like I don't have merge permissions for this repo.

@tsusdere tsusdere merged commit f53ef83 into pages-themes:master Aug 22, 2025
1 check passed
@welcome
Copy link

welcome bot commented Aug 22, 2025

Congrats on getting your first pull request to the Slate theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉

If you're interested in tackling another bug or feature, take a look at the open issues, especially those labeled help wanted.

@tsusdere
Copy link
Contributor

@kabilar oh okay, went ahead and merged your changes, thank you again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants