[B2BP-1363] - Fix storybook image URLs #710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaGiornetta
requested review from
a team,
salvatorediocaro and
simosalsi
as code owners
🦋 Changeset detectedLatest commit: 658b42b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NicolaGiornetta
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 25 25
Lines 1888 1888
Branches 126 126
=======================================
Hits 1878 1878
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jira Pull Request LinkThis Pull Request refers to the following Jira issue B2BP-1363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Storybook broken and / or non Media Library image URLs
List of Changes
Fix broken and/or non media library image URLs for following components
BannerLink
Cards
EditorialSwitch
Editorial
Feature - Also replace background color for better text color contrast
Footer
Framed-Video
Header
Hero
HeroChips (Dark)
HeroCounter (Dark)
Highlight
HowTo
MegaHeader
MediaResources
PageSwitch
Service Carousel
Video-Image
Replace non media libray image URLs for following components
Prefooter
Stats
MegaHeader
Motivation and Context
Resolves broken images in Storybook
How Has This Been Tested?
User is able to see right images in Storybook now.
Screenshots (if appropriate):
Types of changes
Checklist: