[DEV-1951] Add urlreplacemap codec, + tests + mapping function #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-urlreplacemap-codec
tommaso1
requested review from
MarcoPonchia and
marcobottaro
as code owners
🦋 Changeset detectedLatest commit: 59aaf53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MarBert
previously requested changes
Oct 3, 2024
marcobottaro
requested changes
Oct 3, 2024
apps/nextjs-website/src/lib/strapi/__tests__/urlReplaceMap.test.ts
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/lib/strapi/__tests__/urlReplaceMap.test.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: marcobottaro <[email protected]>
…t.ts Co-authored-by: marcobottaro <[email protected]>
Branch is not up to date with base branch@tommaso1 it seems this Pull Request is not updated with base branch. |
6 tasks
marcobottaro
requested changes
Oct 4, 2024
apps/nextjs-website/src/lib/strapi/codecs/UrlReplaceMapCodec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: marcobottaro <[email protected]>
marcobottaro
approved these changes
Oct 8, 2024
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-1951 |
|
Bundle not found for branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Adds the codec to read and parse urlreplacemap from strapi
Depends on [DEV-1950](#1161)
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: