[DEV-2260] Integrate webinar category to webinar template #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-webinar-category-to-website
# Conflicts: # apps/nextjs-website/src/lib/strapi/__tests__/webinars.test.ts # apps/strapi-cms/src/api/webinar-category/controllers/webinar-category.ts
# Conflicts: # apps/nextjs-website/src/components/molecules/DesktopWebinarCategorySelector/DesktopWebinarCategorySelector.tsx # apps/nextjs-website/src/components/molecules/MobileWebinarCategorySelector/MobileWebinarCategorySelector.tsx
MarBert
requested review from
MarcoPonchia,
marcobottaro and
tommaso1
as code owners
🦋 Changeset detectedLatest commit: b05b675 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MarcoPonchia
approved these changes
May 15, 2025
MarcoPonchia
approved these changes
May 15, 2025
There was a problem hiding this comment.
I think that for the current needs is fine 👍 but maybe in the future could be improve this category menu by using a slug or a normalized version of the name instead of an index, to enable the cration of link that redirect user to this webinars list prefilterd by some category regardless the positional value of the array
tommaso1
approved these changes
May 22, 2025
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2260 |
marcobottaro
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Add webinarc category selector to webinar template
Motivation and Context
Allows to filter webinars based on category
How Has This Been Tested?
On localhost
Screenshots (if appropriate):
Types of changes
Checklist: