-
Notifications
You must be signed in to change notification settings - Fork 1
[DEV-2310] turbo upgrade #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-2310] turbo upgrade #1463
Conversation
|
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2310 |
Branch is not up to date with base branch@marcobottaro it seems this Pull Request is not updated with base branch. |
"eslint": "^8.50.0", | ||
"eslint-config-custom": "*", | ||
"typescript": "^5.7.3", | ||
"turbo": "^1.10.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this row was due because of the turbo prune
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turbo shouldn't be a workspace dependency, but in a mono repo, we use turbo to run some commands in any workspace.
so, the scripts of a single workspace (like the strapi-cms
app) should not depend on turbo.
you could accomplish what you are doing now, making explicit the dependency between tasks (in the turbo.json
file and updating (if necessary) your GitHub workflows.
If you do so, you will boost performance because you will also use the turbo cache (if the turbo.json
file is properly configured).
} | ||
"turbo": "^2.5.3" | ||
}, | ||
"packageManager": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to set an npm version here?
If this is necessary, I think you should also change .node-version
file content and set 22.8.0
according to nodejs documentation: https://nodejs.org/dist/index.json
Does current Next and Strapi versions are compatible with npm 10.8.2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left a note about the packageManager
: it is a good practice to add it to the package.json
file.
This adds consistency and makes sure the CI uses the same version used during development.
Moreover, I guess this has been introduced running the codemod to migrate turbo.
This pull request is stale because it has been open for 14 days with no activity. If the pull request is still valid, please update it within 21 days to keep it open or merge it, otherwise it will be closed automatically. |
This pull request was closed because it has been inactive for 21 days since being marked as stale. |
List of Changes
Upgrades turbo to the latest version to allow the upgrade of nextjs
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: