Skip to content

Conversation

tommaso1
Copy link
Collaborator

@tommaso1 tommaso1 commented Jun 6, 2025

List of Changes

Upgrades turbo to the latest version to allow the upgrade of nextjs

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@tommaso1 tommaso1 requested review from a team, MarcoPonchia and marcobottaro as code owners June 6, 2025 09:45
Copy link

changeset-bot bot commented Jun 6, 2025

⚠️ No Changeset found

Latest commit: bf942c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tommaso1 tommaso1 changed the title [DEV-2310] Poc turbo upgrade [DEV-2310] turbo upgrade Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-2310

Copy link
Contributor

Branch is not up to date with base branch

@marcobottaro it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

"eslint": "^8.50.0",
"eslint-config-custom": "*",
"typescript": "^5.7.3",
"turbo": "^1.10.12"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this row was due because of the turbo prune command

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turbo shouldn't be a workspace dependency, but in a mono repo, we use turbo to run some commands in any workspace.

so, the scripts of a single workspace (like the strapi-cms app) should not depend on turbo.
you could accomplish what you are doing now, making explicit the dependency between tasks (in the turbo.json file and updating (if necessary) your GitHub workflows.

If you do so, you will boost performance because you will also use the turbo cache (if the turbo.json file is properly configured).

}
"turbo": "^2.5.3"
},
"packageManager": "[email protected]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set an npm version here?

If this is necessary, I think you should also change .node-version file content and set 22.8.0 according to nodejs documentation: https://nodejs.org/dist/index.json

Does current Next and Strapi versions are compatible with npm 10.8.2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a note about the packageManager: it is a good practice to add it to the package.json file.
This adds consistency and makes sure the CI uses the same version used during development.

Moreover, I guess this has been introduced running the codemod to migrate turbo.

Copy link
Contributor

This pull request is stale because it has been open for 14 days with no activity. If the pull request is still valid, please update it within 21 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Jun 29, 2025
Copy link
Contributor

This pull request was closed because it has been inactive for 21 days since being marked as stale.

@github-actions github-actions bot closed this Jul 22, 2025
@github-actions github-actions bot deleted the poc-turbo-upgrade branch July 22, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants