[DEV-2397] Refactor S3 metadata helpers to include retry logic for fetching file… #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and metadata. Added exponential backoff for retries and improved error logging. Updated subproject commit to indicate a dirty state.
- Implemented retry logic with exponential backoff for `downloadFileAsText()` and `fetchMetadataFromCDN()` - Introduced environment variables `CDN_RETRY_ATTEMPTS` and `CDN_RETRY_DELAY_MS` for customization - Enhanced error handling and logging for CDN fetch failures - Resolved 404 errors on guide pages when CloudFront cache is not warmed up
🦋 Changeset detectedLatest commit: 70a2d25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MarcoPonchia
reviewed
Jul 2, 2025
Comment on lines
64
to
76
| if (attempt < RETRY_ATTEMPTS) { | ||
| const delayMs = INITIAL_RETRY_DELAY_MS * Math.pow(2, attempt - 1); // Exponential backoff | ||
| console.log(`Retrying in ${delayMs}ms...`); | ||
| await delay(delayMs); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| console.error( | ||
| `Failed to download file after ${RETRY_ATTEMPTS} attempts:`, | ||
| lastError | ||
| ); | ||
| return; |
There was a problem hiding this comment.
isntead of duplicate code for retry maybe we can have a shared function that handle retries used in both downloadFileAsText and fetchMetadataFromCDN
- Introduced a `withRetries` function to handle retry logic for asynchronous operations, enhancing code reusability. - Updated `downloadFileAsText` and `fetchMetadataFromCDN` to leverage the new retry function, improving error handling and logging. - Maintained existing functionality while streamlining the retry process for better maintainability.
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2397 |
Branch is not up to date with base branch@tommaso1 it seems this Pull Request is not updated with base branch. |
MarcoPonchia
approved these changes
Jul 3, 2025
marcobottaro
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and metadata. Added exponential backoff for retries and improved error logging. Updated subproject commit to indicate a dirty state.
List of Changes
downloadFileAsText()andfetchMetadataFromCDN()functionsCDN_RETRY_ATTEMPTS(default: 3) andCDN_RETRY_DELAY_MS(default: 5000ms)Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: