-
Notifications
You must be signed in to change notification settings - Fork 1
[DEV-2549] New Webinars type and makeWebinarsProps function #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcobottaro
merged 44 commits into
main
from
DEV-2549-switch-from-webinars-codec-to-ts-type
Sep 2, 2025
Merged
[DEV-2549] New Webinars type and makeWebinarsProps function #1594
marcobottaro
merged 44 commits into
main
from
DEV-2549-switch-from-webinars-codec-to-ts-type
Sep 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trapi-with-standard-fetch' into DEV-2461-create-new-fetch-from-strapi-with-standard-fetch
…type # Conflicts: # apps/nextjs-website/src/lib/strapi/codecs/GuideListPagesCodec.ts # apps/nextjs-website/src/lib/strapi/makeProps/makeGuideListPages.ts
…type # Conflicts: # apps/nextjs-website/src/lib/strapi/makeProps/makeGuideListPages.ts
…tandard-fetch # Conflicts: # apps/nextjs-website/src/lib/strapi/codecs/GuideListPagesCodec.ts # apps/nextjs-website/src/lib/strapi/makeProps/makeGuideListPages.ts
…ch' into DEV-2527-switch-from-overviews-codec-to--ts-type # Conflicts: # apps/nextjs-website/src/lib/strapi/makeProps/makeGuideListPages.ts
tommaso1
approved these changes
Aug 5, 2025
Branch is not up to date with base branch@Sebastiano-Bertolin it seems this Pull Request is not updated with base branch. |
tommaso1
previously approved these changes
Aug 26, 2025
marcobottaro
previously approved these changes
Sep 1, 2025
Base automatically changed from
DEV-2527-switch-from-overviews-codec-to--ts-type
to
main
September 2, 2025 13:50
The base branch was changed.
…webinars-codec-to-ts-type
marcobottaro
requested changes
Sep 2, 2025
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2549 |
marcobottaro
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Add Webinars type and a new makeWebinarsProps using it
add tests for the new makeWebinars function
Motivation and Context
Remove io-ts codecs
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: