Skip to content

Conversation

uolter
Copy link
Member

@uolter uolter commented Aug 18, 2025

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

changeset-bot bot commented Aug 18, 2025

🦋 Changeset detected

Latest commit: 6857c6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
infrastructure Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@marcobottaro marcobottaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the changeset file

@uolter
Copy link
Member Author

uolter commented Sep 11, 2025

@marcobottaro (cc @MarcoPonchia )
With this PR, I am completely removing the lambda from the CloudFront distribution that serves static-contents.
Previously, it was associated with the static site distribution that we removed.
My question is: is it okay to get rid of the lambda altogether, or is it better to modify it and remove only the part that deals with adding the .html extension?
The lambda function we are talking about is: https://github.com/pagopa/developer-portal/blob/fix/assets-with-no-extension/apps/cloudfront-functions/src/viewer-request-handler.ts
Let's chat up the next stand-up.

Copy link
Contributor

This pull request is stale because it has been open for 14 days with no activity. If the pull request is still valid, please update it within 21 days to keep it open or merge it, otherwise it will be closed automatically.

@github-actions github-actions bot added the stale label Sep 29, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Branch is not up to date with base branch

@marcobottaro it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-2511

@marcobottaro
Copy link
Collaborator

@marcobottaro (cc @MarcoPonchia ) With this PR, I am completely removing the lambda from the CloudFront distribution that serves static-contents. Previously, it was associated with the static site distribution that we removed. My question is: is it okay to get rid of the lambda altogether, or is it better to modify it and remove only the part that deals with adding the .html extension? The lambda function we are talking about is: https://github.com/pagopa/developer-portal/blob/fix/assets-with-no-extension/apps/cloudfront-functions/src/viewer-request-handler.ts Let's chat up the next stand-up.

I don't think it's ok to get rid of the lambda, we should just focus on the logic in viewer-request-handler.ts

// Always add .html if there's no file extension, including special cases if ( !isGitbookAssets && !isWoff2 && (!/\.[a-zA-Z]+$/.test(uri) || isSpecialCase) ) { request.uri += '.html'; }

@github-actions github-actions bot removed the stale label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants