Skip to content

Conversation

MarcoPonchia
Copy link
Collaborator

@MarcoPonchia MarcoPonchia commented Sep 17, 2025

Depends on: #1696, #1699

List of Changes

  • Use synced solution and synced solution list pages
  • Use synced release-notes
  • Add deprecated files

Motivation and Context

Manage sync FE with data coming from gitbook avoding to re-deploy

How Has This Been Tested?

Manually on localhost

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MarcoPonchia MarcoPonchia self-assigned this Sep 17, 2025
Copy link

changeset-bot bot commented Sep 17, 2025

🦋 Changeset detected

Latest commit: 4039ab2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MarcoPonchia MarcoPonchia changed the base branch from main to DEV-2818-update-script-to-generate-synced-data-in-s3 September 17, 2025 15:22
Copy link
Collaborator Author

@MarcoPonchia MarcoPonchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all file with deprecated comment

Base automatically changed from DEV-2818-update-script-to-generate-synced-data-in-s3 to main September 18, 2025 08:51
Copy link

dpulls bot commented Sep 18, 2025

🎉 All dependencies have been resolved !

@MarcoPonchia MarcoPonchia marked this pull request as ready for review September 30, 2025 15:35
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-2819

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the data fetching strategy for solutions and release notes from direct Strapi API calls to using synced responses stored in CDN. This change enables frontend synchronization with GitBook data without requiring re-deployments.

  • Removes direct Strapi API fetches for solutions, solution list pages, and release notes
  • Replaces with CDN-based synced response fetching for these content types
  • Adds proper error handling and validation for the new data source

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
apps/nextjs-website/src/lib/strapi/fetches/fetchSolutions.ts Removed - no longer needed with synced response approach
apps/nextjs-website/src/lib/strapi/fetches/fetchSolutionListPage.ts Removed - replaced by CDN fetching
apps/nextjs-website/src/lib/strapi/fetches/fetchReleaseNotes.ts Removed - replaced by CDN fetching
apps/nextjs-website/src/lib/strapi/fetches/fetchGuides.ts Removed - replaced by CDN fetching
apps/nextjs-website/src/lib/strapi/fetches/fetchGuideListPages.ts Removed - replaced by CDN fetching
apps/nextjs-website/src/lib/cmsApi.ts Updated to use synced response functions from gitbook-docs package
.changeset/shaggy-baths-bake.md Documents the breaking change for version tracking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

export const getSolutionsProps = async () => {
const strapiSolutions = await fetchSolutions(buildEnv);
return makeSolutionsProps(strapiSolutions);
// TODO: restore this when Strapi will manage guides metadata
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment refers to 'guides metadata' but the function getSolutionsProps is handling solutions data, not guides. The comment should be updated to reflect the correct content type.

Suggested change
// TODO: restore this when Strapi will manage guides metadata
// TODO: restore this when Strapi will manage solutions metadata

Copilot uses AI. Check for mistakes.

jsonMetadata?: JsonMetadata
) => {
const strapiSolutions = await fetchSolution(solutionsSlug)(buildEnv);
// TODO: restore this when Strapi will manage guides metadata
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment refers to 'guides metadata' but the function getSolutionProps is handling solutions data, not guides. The comment should be updated to reflect the correct content type.

Suggested change
// TODO: restore this when Strapi will manage guides metadata
// TODO: restore this when Strapi will manage solutions metadata

Copilot uses AI. Check for mistakes.

jsonMetadata?: JsonMetadata
) => {
const strapiReleaseNotes = await fetchReleaseNote(productSlug)(buildEnv);
// TODO: restore this when Strapi will manage guides metadata
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment refers to 'guides metadata' but the function getReleaseNoteProps is handling release notes data, not guides. The comment should be updated to reflect the correct content type.

Suggested change
// TODO: restore this when Strapi will manage guides metadata
// TODO: restore this when Strapi will manage release notes metadata

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants