[CAI-609] chatbot-evaluate settings #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batdevis
requested review from
a team,
MarcoPonchia,
marcobottaro and
tommaso1
as code owners
🦋 Changeset detectedLatest commit: af1254b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
batdevis
changed the title
mdciri
requested changes
Oct 10, 2025
mdciri
requested changes
Oct 14, 2025
| aws_secret_access_key=os.getenv("CHB_AWS_SECRET_ACCESS_KEY"), | ||
| ) | ||
| sts = session.client("sts") | ||
| sts = SETTINGS.AWS_SESSION.client("sts") |
There was a problem hiding this comment.
sts = AWS_SESSION.client("sts")and not
sts = SETTINGS.AWS_SESSION.client("sts")There was a problem hiding this comment.
done, but it's not my intention to touch this tests.
Jira Pull Request LinkThis Pull Request refers to the following Jira issue CAI-609 |
mdciri
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Align settings.py file with chatbot settings.py file.
Motivation and Context
We want the code to be as consistent as possible
How Has This Been Tested?
locally
Screenshots (if appropriate):
Types of changes
Checklist: