Skip to content

[DEV-3038] SiteHeader always visible on desktop #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[DEV-3038] SiteHeader always visible on desktop #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ae3de4a
Change product header behaviour on desktop site - site header always …
Sebastiano-Bertolin Oct 16, 2025
8597370
Fix
Sebastiano-Bertolin Oct 16, 2025
3044370
Fix gitbooktemplate content margins
Sebastiano-Bertolin Oct 16, 2025
5308221
Add changeset
Sebastiano-Bertolin Oct 16, 2025
a2ec21a
Merge branch 'main' into DEV-3038-main-manu-always-visible
Sebastiano-Bertolin Oct 16, 2025
d4ea782
Merge branch 'main' into DEV-3038-main-manu-always-visible
Sebastiano-Bertolin Oct 16, 2025
efda240
Fix padding in product layout
Sebastiano-Bertolin Oct 16, 2025
b802b2e
Fix paddings in tutorial and use case templates
Sebastiano-Bertolin Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/beige-cobras-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"nextjs-website": minor
---

Change ProductHeader behaviour to be fixed on desktop and maintain the old behaviour on mobile
16 changes: 10 additions & 6 deletions apps/nextjs-website/src/components/atoms/GuideMenu/GuideMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,20 @@ const GuideMenu = (menuProps: GuideMenuProps) => {
const segments = currentPath.split('/');
const expanded = segments.map((_, i) => segments.slice(0, i + 1).join('/'));

const top = scrollUp ? SITE_HEADER_HEIGHT : 0;
const topOffsetXs = scrollUp ? SITE_HEADER_HEIGHT : 0;

const height = `calc(100vh - ${top}px)`;
const height = `calc(100vh - ${topOffsetXs}px)`;

const topStyle = menuProps.hasHeader
? { xs: top + 62, sm: top + 90, md: top + 77 }
? {
xs: topOffsetXs + 62,
sm: topOffsetXs + 90,
md: SITE_HEADER_HEIGHT + 77,
}
: {
xs: top,
sm: top,
md: top,
xs: topOffsetXs,
sm: topOffsetXs,
md: topOffsetXs,
};

const handleClick = useCallback(() => {
Expand Down
4 changes: 2 additions & 2 deletions apps/nextjs-website/src/components/atoms/ProductHeader/ProductHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import { Product } from '@/lib/types/product';
import { Box, useTheme } from '@mui/material';
import { Header } from '@/editorialComponents/Header';
import React, { FC } from 'react';
import { useScrollUp } from '@/components/atoms/ProductHeader/useScrollUp';
import { SITE_HEADER_HEIGHT } from '@/components/molecules/SiteHeader/SiteHeader';
import { useTranslations } from 'next-intl';
import { useScrollUp } from './useScrollUp';

type ProductHeaderProps = {
product: Product;
Expand All @@ -29,7 +29,7 @@ const ProductHeader: FC<ProductHeaderProps> = ({ product, path }) => {
<Box
sx={{
position: 'fixed',
top: scrollUp ? SITE_HEADER_HEIGHT : 0,
top: { xs: scrollUp ? SITE_HEADER_HEIGHT : 0, md: SITE_HEADER_HEIGHT },
zIndex: scrollUp ? 90 : 250,
transition: 'top 0.5s linear',
width: '100vw',
Expand Down
3 changes: 2 additions & 1 deletion apps/nextjs-website/src/components/molecules/SiteHeader/SiteHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ const SiteHeader = (
return (
<Box
sx={{
position: 'sticky',
position: 'fixed',
top: 0,
height: SITE_HEADER_HEIGHT,
zIndex: 100,
width: '100vw',
}}
>
<Stack
Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/components/organisms/ProductLayout/ProductLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const ProductLayout: FC<LayoutPropsWithChildren> = ({
{structuredData}
{product && path && <ProductHeader product={product} path={path} />}
{product && showBreadcrumbs && (
<EContainer sx={{ marginTop: 10, paddingTop: 3 }}>
<EContainer sx={{ marginTop: 15, paddingTop: 3 }}>
<ProductBreadcrumbs
breadcrumbs={[...productPageToBreadcrumbs(product, paths)]}
/>
Expand Down
9 changes: 7 additions & 2 deletions apps/nextjs-website/src/components/templates/GitBookTemplate/GitBookTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,17 @@ const GitBookTemplate = ({
versions,
breadcrumbs,
menuDistanceFromTop,
contentMarginTop = 75,
contentMarginTop,
hasHeader = true,
hasInPageMenu = true,
}: GitBookTemplateProps) => {
const t = useTranslations();
const paddingTop = hasHeader ? '60px' : '-80px';
const responsiveContentMarginTop = (contentMarginTop &&
`${contentMarginTop}px`) || {
xs: '30px',
md: '110px',
};

return (
<FragmentProvider>
Expand All @@ -66,7 +71,7 @@ const GitBookTemplate = ({
)}
<Stack
sx={{
margin: `${contentMarginTop} auto`,
marginTop: responsiveContentMarginTop,
paddingTop: 3,
flexGrow: { lg: 1 },
maxWidth: {
Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/components/templates/TutorialTemplate/TutorialTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const TutorialTemplate = ({
// 80px is the height of the product header
marginTop: '80px',
marginX: 'auto',
paddingTop: 3,
paddingTop: 8,
px: { xs: 4, lg: 0 },
}}
>
Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/components/templates/UseCaseTemplate/UseCaseTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const UseCaseTemplate = ({
>
{product && (
<Box
paddingY={'20px'}
paddingY={'74px'}
marginTop={{ sm: '64px', md: '76px' }}
style={{
backgroundColor: palette.grey[50],
Expand Down