-
Notifications
You must be signed in to change notification settings - Fork 1
[CAI-612] Update sync worflow #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b3e8b1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/gitbook-docs/src/scripts/generateStrapiResponseFile.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds centralized Strapi type definitions and introduces a new script plus workflow step to fetch Strapi products, APIs data, and sitemap content, then upload them to S3.
- Extracts Strapi-related interfaces into a new helpers/strapiTypes.ts module and updates imports accordingly.
- Adds generateStrapiResponseFile.ts script and a workflow step to run it.
- Updates package.json to expose a new npm script (with a path inconsistency).
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
packages/gitbook-docs/src/scripts/generateUrlParsingMetadata.ts | Adjusts imports to use new centralized Strapi type definitions. |
packages/gitbook-docs/src/scripts/generateStrapiResponseFile.ts | New script to fetch Strapi data and sitemap, then write them to S3. |
packages/gitbook-docs/src/scripts/generateSolutionsMetadata.ts | Updates StrapiSolution import source. |
packages/gitbook-docs/src/scripts/generateReleaseNotesMetadata.ts | Updates StrapiReleaseNote import source. |
packages/gitbook-docs/src/scripts/generateGuidesMetadata.ts | Splits imports; moves StrapiGuide to new types file. |
packages/gitbook-docs/src/helpers/strapiTypes.ts | New file containing Strapi-related interfaces. |
packages/gitbook-docs/src/helpers/guidesMetadataHelper.ts | Removes Strapi interfaces now relocated to strapiTypes.ts. |
packages/gitbook-docs/package.json | Adds npm script for generating Strapi response files (with incorrect filename). |
.github/workflows/sync_gitbook_docs.yaml | Adds step to run the new Strapi response generation script (references mismatched script filename). |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/gitbook-docs/src/scripts/generateStrapiResponseFiles.ts
Outdated
Show resolved
Hide resolved
packages/gitbook-docs/src/scripts/generateStrapiResponseFiles.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Branch is not up to date with base branch@MarBert it seems this Pull Request is not updated with base branch. |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue CAI-612 |
List of Changes
Adds the sitemap and files with products and apis-data fetched from strapi to s3 bucket
Motivation and Context
Needed to fix issue with lambda
How Has This Been Tested?
It has not been tested
Screenshots (if appropriate):
Types of changes
Checklist: