Skip to content

Conversation

MarBert
Copy link
Collaborator

@MarBert MarBert commented Oct 16, 2025

List of Changes

Adds the sitemap and files with products and apis-data fetched from strapi to s3 bucket

Motivation and Context

Needed to fix issue with lambda

How Has This Been Tested?

It has not been tested

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MarBert MarBert self-assigned this Oct 16, 2025
Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: b3e8b1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MarBert MarBert requested a review from marcobottaro October 17, 2025 07:48
@marcobottaro marcobottaro requested a review from Copilot October 17, 2025 14:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds centralized Strapi type definitions and introduces a new script plus workflow step to fetch Strapi products, APIs data, and sitemap content, then upload them to S3.

  • Extracts Strapi-related interfaces into a new helpers/strapiTypes.ts module and updates imports accordingly.
  • Adds generateStrapiResponseFile.ts script and a workflow step to run it.
  • Updates package.json to expose a new npm script (with a path inconsistency).

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/gitbook-docs/src/scripts/generateUrlParsingMetadata.ts Adjusts imports to use new centralized Strapi type definitions.
packages/gitbook-docs/src/scripts/generateStrapiResponseFile.ts New script to fetch Strapi data and sitemap, then write them to S3.
packages/gitbook-docs/src/scripts/generateSolutionsMetadata.ts Updates StrapiSolution import source.
packages/gitbook-docs/src/scripts/generateReleaseNotesMetadata.ts Updates StrapiReleaseNote import source.
packages/gitbook-docs/src/scripts/generateGuidesMetadata.ts Splits imports; moves StrapiGuide to new types file.
packages/gitbook-docs/src/helpers/strapiTypes.ts New file containing Strapi-related interfaces.
packages/gitbook-docs/src/helpers/guidesMetadataHelper.ts Removes Strapi interfaces now relocated to strapiTypes.ts.
packages/gitbook-docs/package.json Adds npm script for generating Strapi response files (with incorrect filename).
.github/workflows/sync_gitbook_docs.yaml Adds step to run the new Strapi response generation script (references mismatched script filename).

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Branch is not up to date with base branch

@MarBert it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

Copy link
Contributor

github-actions bot commented Oct 17, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue CAI-612

@marcobottaro marcobottaro merged commit 6d0f79a into main Oct 17, 2025
14 checks passed
@marcobottaro marcobottaro deleted the CAI-612-update-sync-worflow branch October 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants