Add Azure Front Door support to static assets deploy action #1000
Conversation
🦋 Changeset detectedLatest commit: cad8668 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (45.86%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
===========================================
- Coverage 67.85% 45.86% -22.00%
===========================================
Files 31 49 +18
Lines 840 1969 +1129
Branches 146 222 +76
===========================================
+ Hits 570 903 +333
- Misses 258 1047 +789
- Partials 12 19 +7 🚀 New features to boost your workflow:
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-1000.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-1000.westeurope.1.azurestaticapps.net |
| default: '' | ||
| default: "" | ||
| use_cdn_classic: | ||
| description: Set to true to use Azure CDN Classic instead of Front Door (default is Front Door). |
There was a problem hiding this comment.
| description: Set to true to use Azure CDN Classic instead of Front Door (default is Front Door). | |
| description: Set to true to use Azure CDN Classic (deprecated) instead of Front Door (default is Front Door). |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "static-assets-deploy": patch | |||
There was a problem hiding this comment.
question: what if someone is using the old action that points to the deleted file?
There was a problem hiding this comment.
question: wouldn't renaming the action result in a breaking change?
There was a problem hiding this comment.
question: what about azure-static-assets-deploy ?
| @@ -0,0 +1,143 @@ | |||
| # Static Assets Deploy | |||
There was a problem hiding this comment.
| # Static Assets Deploy | |
| # Azure Static Assets Deploy |
| description: Path to the files directory (Default is 'dist') | ||
| required: false | ||
| default: "dist" | ||
| working_directory: |
There was a problem hiding this comment.
thoughts: what about having just one between working_dir and sync_dir? if we have the full path relative to the root ie.
working_directory/sync_dir_name
we can obtain working_directory and sync_dir_name
3 participants
Extended the static assets deploy action to support both Azure Front Door and Azure CDN Classic.
use_cdn_classicboolean flag to switch between Front Door (default) and CDN Classic.github/actions/cdn-code-deploytoactions/static-assets-deployuse_cdn_classic: truefor CDN Classic)release-azure-cdn-v1.yamltorelease-azure-staticassets-v1.yamlResolves: CES-1329