Skip to content

Add examples and e2e tests to AppConfiguration modules#1106

Draft
Krusty93 wants to merge 10 commits intomainfrom
CES-1469-aggiungere-esempi-del-modulo-da-usare-per-i-test-e-2-e
Draft

Add examples and e2e tests to AppConfiguration modules#1106
Krusty93 wants to merge 10 commits intomainfrom
CES-1469-aggiungere-esempi-del-modulo-da-usare-per-i-test-e-2-e

Conversation

@Krusty93
Copy link
Contributor

Depends on #1105

Resolves CES-1469

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: 155fa19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

private_dns_zone_resource_group_name = data.azurerm_resource_group.network.name

key_vault = {
has_rbac_support = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: what's this for? can we link related docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it refers to role assignment module. It says whether the indicated keyvault uses access policies or RBAC as access model

@dpulls
Copy link

dpulls bot commented Dec 3, 2025

🎉 All dependencies have been resolved !

@Krusty93 Krusty93 force-pushed the CES-1469-aggiungere-esempi-del-modulo-da-usare-per-i-test-e-2-e branch from bde111b to 4693925 Compare February 13, 2026 15:16
@Krusty93 Krusty93 deployed to infra-dev-ci February 13, 2026 15:39 — with GitHub Actions Active
@github-actions
Copy link
Contributor

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..................................(no files to check)Skipped
Terraform Providers Lock (on staged .terraform.lock.hcl files).......................Passed
- hook id: terraform_providers_lock_staged
- duration: 0.08s

No .terraform.lock.hcl files to process.

Terraform fmt........................................................................Passed
terraform_docs on modules............................................................Failed
- hook id: terraform_docs
- files were modified by this hook
terraform_docs on resources......................................(no files to check)Skipped
Terraform validate with tflint.......................................................Passed
Terraform validate...............................................(no files to check)Skipped
Terraform validate with trivy........................................................Passed
All changes made by hooks:
diff --git a/infra/modules/azure_app_configuration/examples/keyvault_integration/README.md b/infra/modules/azure_app_configuration/examples/keyvault_integration/README.md
index 63be0f31..1b0f3066 100644
--- a/infra/modules/azure_app_configuration/examples/keyvault_integration/README.md
+++ b/infra/modules/azure_app_configuration/examples/keyvault_integration/README.md
@@ -20,9 +20,12 @@
 
 | Name | Type |
 |------|------|
+| [azurerm_container_group.private_app](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/container_group) | resource |
 | [azurerm_key_vault.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/key_vault) | resource |
 | [azurerm_private_endpoint.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/private_endpoint) | resource |
 | [azurerm_resource_group.e2e_appcs](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/resource_group) | resource |
+| [azurerm_subnet.private_app](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/subnet) | resource |
+| [dx_available_subnet_cidr.private_app](https://registry.terraform.io/providers/hashicorp/dx/latest/docs/resources/available_subnet_cidr) | resource |
 | [random_integer.appcs_instance](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/integer) | resource |
 | [azurerm_client_config.current](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/client_config) | data source |
 | [azurerm_private_dns_zone.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/private_dns_zone) | data source |
@@ -40,4 +43,5 @@ No inputs.
 | Name | Description |
 |------|-------------|
 | <a name="output_name"></a> [name](#output\_name) | n/a |
+| <a name="output_private_app_ip_address"></a> [private\_app\_ip\_address](#output\_private\_app\_ip\_address) | n/a |
 <!-- END_TF_DOCS -->
diff --git a/infra/modules/azure_app_configuration/examples/network_access/README.md b/infra/modules/azure_app_configuration/examples/network_access/README.md
index d314ca00..77b308f7 100644
--- a/infra/modules/azure_app_configuration/examples/network_access/README.md
+++ b/infra/modules/azure_app_configuration/examples/network_access/README.md
@@ -15,7 +15,7 @@
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_integration_github_roles"></a> [integration\_github\_roles](#module\_integration\_github\_roles) | pagopa-dx/azure-role-assignments/azurerm | ~> 1.0 |
-| <a name="module_private_appcs"></a> [private\_appcs](#module\_private\_appcs) | ../../ | n/a |
+| <a name="module_private_appcs"></a> [private\_appcs](#module\_private\_appcs) | pagopa-dx/azure-app-configuration/azurerm | ~> 0.0 |
 | <a name="module_role_appcs_private"></a> [role\_appcs\_private](#module\_role\_appcs\_private) | pagopa-dx/azure-role-assignments/azurerm | ~> 1.0 |
 | <a name="module_role_appcs_public"></a> [role\_appcs\_public](#module\_role\_appcs\_public) | pagopa-dx/azure-role-assignments/azurerm | ~> 1.0 |
 
diff --git a/infra/modules/azure_app_configuration/tests/setup/README.md b/infra/modules/azure_app_configuration/tests/setup/README.md
index 11a1e7d4..a46df959 100644
--- a/infra/modules/azure_app_configuration/tests/setup/README.md
+++ b/infra/modules/azure_app_configuration/tests/setup/README.md
@@ -1,14 +1,13 @@
 # setup
 
 <!-- BEGIN_TF_DOCS -->
-
 ## Requirements
 
-| Name                                                               | Version |
-| ------------------------------------------------------------------ | ------- |
-| <a name="requirement_azurerm"></a> [azurerm](#requirement_azurerm) | ~> 4.0  |
-| <a name="requirement_dx"></a> [dx](#requirement_dx)                | ~> 0.8  |
-| <a name="requirement_random"></a> [random](#requirement_random)    | ~> 3.7  |
+| Name | Version |
+|------|---------|
+| <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | ~> 4.0 |
+| <a name="requirement_dx"></a> [dx](#requirement\_dx) | ~> 0.8 |
+| <a name="requirement_random"></a> [random](#requirement\_random) | ~> 3.7 |
 
 ## Modules
 
@@ -16,40 +15,39 @@ No modules.
 
 ## Resources
 
-| Name                                                                                                                                             | Type        |
-| ------------------------------------------------------------------------------------------------------------------------------------------------ | ----------- |
-| [azurerm_key_vault.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/key_vault)                                | resource    |
-| [azurerm_private_endpoint.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/private_endpoint)                  | resource    |
-| [azurerm_resource_group.sut](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/resource_group)                     | resource    |
-| [random_integer.appcs_kv_instance](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/integer)                       | resource    |
-| [azurerm_client_config.current](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/client_config)                | data source |
-| [azurerm_private_dns_zone.appcs](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/private_dns_zone)            | data source |
-| [azurerm_private_dns_zone.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/private_dns_zone)               | data source |
-| [azurerm_resource_group.network](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/resource_group)              | data source |
-| [azurerm_resource_group.test](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/resource_group)                 | data source |
-| [azurerm_subnet.pep](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/subnet)                                  | data source |
+| Name | Type |
+|------|------|
+| [azurerm_key_vault.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/key_vault) | resource |
+| [azurerm_private_endpoint.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/private_endpoint) | resource |
+| [azurerm_resource_group.sut](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/resource_group) | resource |
+| [random_integer.appcs_kv_instance](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/integer) | resource |
+| [azurerm_client_config.current](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/client_config) | data source |
+| [azurerm_private_dns_zone.appcs](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/private_dns_zone) | data source |
+| [azurerm_private_dns_zone.kv](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/private_dns_zone) | data source |
+| [azurerm_resource_group.network](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/resource_group) | data source |
+| [azurerm_resource_group.test](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/resource_group) | data source |
+| [azurerm_subnet.pep](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/subnet) | data source |
 | [azurerm_user_assigned_identity.test](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/user_assigned_identity) | data source |
-| [azurerm_virtual_network.vnet](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/virtual_network)               | data source |
+| [azurerm_virtual_network.vnet](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/virtual_network) | data source |
 
 ## Inputs
 
-| Name                                                               | Description                         | Type                                                                                                                                                                                | Default | Required |
-| ------------------------------------------------------------------ | ----------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------- | :------: |
-| <a name="input_environment"></a> [environment](#input_environment) | n/a                                 | <pre>object({<br/> prefix = string<br/> env_short = string<br/> location = string<br/> domain = optional(string)<br/> app_name = string<br/> instance_number = string<br/> })</pre> | n/a     |   yes    |
-| <a name="input_tags"></a> [tags](#input_tags)                      | Tags to apply to setup resources    | `map(string)`                                                                                                                                                                       | n/a     |   yes    |
-| <a name="input_test_kind"></a> [test_kind](#input_test_kind)       | A value between integration and e2e | `string`                                                                                                                                                                            | n/a     |   yes    |
+| Name | Description | Type | Default | Required |
+|------|-------------|------|---------|:--------:|
+| <a name="input_environment"></a> [environment](#input\_environment) | n/a | <pre>object({<br/>    prefix          = string<br/>    env_short       = string<br/>    location        = string<br/>    domain          = optional(string)<br/>    app_name        = string<br/>    instance_number = string<br/>  })</pre> | n/a | yes |
+| <a name="input_tags"></a> [tags](#input\_tags) | Tags to apply to setup resources | `map(string)` | n/a | yes |
+| <a name="input_test_kind"></a> [test\_kind](#input\_test\_kind) | A value between integration and e2e | `string` | n/a | yes |
 
 ## Outputs
 
-| Name                                                                                                                                            | Description |
-| ----------------------------------------------------------------------------------------------------------------------------------------------- | ----------- |
-| <a name="output_key_vaults"></a> [key_vaults](#output_key_vaults)                                                                               | n/a         |
-| <a name="output_managed_identity_principal_id"></a> [managed_identity_principal_id](#output_managed_identity_principal_id)                      | n/a         |
-| <a name="output_private_dns_zone_appcs"></a> [private_dns_zone_appcs](#output_private_dns_zone_appcs)                                           | n/a         |
-| <a name="output_private_dns_zone_resource_group_name"></a> [private_dns_zone_resource_group_name](#output_private_dns_zone_resource_group_name) | n/a         |
-| <a name="output_resource_group_name"></a> [resource_group_name](#output_resource_group_name)                                                    | n/a         |
-| <a name="output_subnet_pep_id"></a> [subnet_pep_id](#output_subnet_pep_id)                                                                      | n/a         |
-| <a name="output_subscription_id"></a> [subscription_id](#output_subscription_id)                                                                | n/a         |
-| <a name="output_virtual_network"></a> [virtual_network](#output_virtual_network)                                                                | n/a         |
-
+| Name | Description |
+|------|-------------|
+| <a name="output_key_vaults"></a> [key\_vaults](#output\_key\_vaults) | n/a |
+| <a name="output_managed_identity_principal_id"></a> [managed\_identity\_principal\_id](#output\_managed\_identity\_principal\_id) | n/a |
+| <a name="output_private_dns_zone_appcs"></a> [private\_dns\_zone\_appcs](#output\_private\_dns\_zone\_appcs) | n/a |
+| <a name="output_private_dns_zone_resource_group_name"></a> [private\_dns\_zone\_resource\_group\_name](#output\_private\_dns\_zone\_resource\_group\_name) | n/a |
+| <a name="output_resource_group_name"></a> [resource\_group\_name](#output\_resource\_group\_name) | n/a |
+| <a name="output_subnet_pep_id"></a> [subnet\_pep\_id](#output\_subnet\_pep\_id) | n/a |
+| <a name="output_subscription_id"></a> [subscription\_id](#output\_subscription\_id) | n/a |
+| <a name="output_virtual_network"></a> [virtual\_network](#output\_virtual\_network) | n/a |
 <!-- END_TF_DOCS -->

Generated on Fri Feb 13 15:40:08 UTC 2026
Run all checks on modified files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants