Add new tests for CDN modules by mamu0 · Pull Request #1283 · pagopa/dx

mamu0 · 2026-02-03T08:58:59Z

This pull request introduces new test format with Unit, Contract, Integration and E2E tests.

depends-on: #1265
Resolves: CES-1661

- Introduced logic to handle existing CDN FrontDoor profiles. - Updated resource references to use local variables for profile ID and identity. - Added WAF policy and security policy resources with conditional creation. - Enhanced origin configurations to support managed identity for storage access. - Updated outputs to reflect changes in resource handling.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…, add profile SKU check for WAF compatibility

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

changeset-bot · 2026-02-03T08:59:06Z

🦋 Changeset detected

Latest commit: ff26d19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
azure_cdn	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-02-03T08:59:58Z

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..........................................Passed

_{Generated on Tue Feb 3 08:59:57 UTC 2026
Run lock_modules on folder: infra/resources/prod/}

github-actions · 2026-02-03T09:01:06Z

📖 Terraform Plan (infra/resources/prod) - success

Show Plan

  # module.mcp_registry.module.portal.azurerm_cdn_frontdoor_endpoint.this will be updated in-place
  ~ resource "azurerm_cdn_frontdoor_endpoint" "this" {
        id                       = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-common-rg-01/providers/Microsoft.Cdn/profiles/dx-p-weu-mcp-registry-afd-01/afdEndpoints/dx-p-weu-mcp-registry-fde-01"
        name                     = "dx-p-weu-mcp-registry-fde-01"
      ~ tags                     = {
            "CostCenter"     = "TS000 - Tecnologia e Servizi"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "Developer Experience"
            "ModuleName"     = "azure_cdn"
            "ModuleSource"   = "DX"
          ~ "ModuleVersion"  = "0.3.2" -> "0.4.0"
            "Owner"          = "DevEx"
            "Source"         = "https://github.com/pagopa/dx/blob/main/infra/resources/prod"
        }
        # (3 unchanged attributes hidden)
    }

  # module.mcp_registry.module.portal.azurerm_cdn_frontdoor_profile.this will be updated in-place
  ~ resource "azurerm_cdn_frontdoor_profile" "this" {
        id                       = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-common-rg-01/providers/Microsoft.Cdn/profiles/dx-p-weu-mcp-registry-afd-01"
        name                     = "dx-p-weu-mcp-registry-afd-01"
      ~ tags                     = {
            "CostCenter"     = "TS000 - Tecnologia e Servizi"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "Developer Experience"
            "ModuleName"     = "azure_cdn"
            "ModuleSource"   = "DX"
          ~ "ModuleVersion"  = "0.3.2" -> "0.4.0"
            "Owner"          = "DevEx"
            "Source"         = "https://github.com/pagopa/dx/blob/main/infra/resources/prod"
        }
        # (4 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.mcp_registry.module.portal.azurerm_dns_cname_record.this["mcp.dx.pagopa.it"] will be updated in-place
  ~ resource "azurerm_dns_cname_record" "this" {
        id                  = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-network-rg-01/providers/Microsoft.Network/dnsZones/dx.pagopa.it/CNAME/mcp"
        name                = "mcp"
      ~ tags                = {
            "CostCenter"     = "TS000 - Tecnologia e Servizi"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "Developer Experience"
            "ModuleName"     = "azure_cdn"
            "ModuleSource"   = "DX"
          ~ "ModuleVersion"  = "0.3.2" -> "0.4.0"
            "Owner"          = "DevEx"
            "Source"         = "https://github.com/pagopa/dx/blob/main/infra/resources/prod"
        }
        # (6 unchanged attributes hidden)
    }

  # module.mcp_registry.module.portal.azurerm_dns_txt_record.validation["mcp.dx.pagopa.it"] will be updated in-place
  ~ resource "azurerm_dns_txt_record" "validation" {
        id                  = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-network-rg-01/providers/Microsoft.Network/dnsZones/dx.pagopa.it/TXT/_dnsauth.mcp"
        name                = "_dnsauth.mcp"
      ~ tags                = {
            "Cdn"            = "dx-p-weu-mcp-registry-afd-01"
            "CostCenter"     = "TS000 - Tecnologia e Servizi"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "Developer Experience"
            "ModuleName"     = "azure_cdn"
            "ModuleSource"   = "DX"
          ~ "ModuleVersion"  = "0.3.2" -> "0.4.0"
            "Origin"         = "mcp.dx.pagopa.it"
            "Owner"          = "DevEx"
            "Source"         = "https://github.com/pagopa/dx/blob/main/infra/resources/prod"
        }
        # (4 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 4 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.mcp_registry.module.portal.azurerm_cdn_frontdoor_custom_domain.this["mcp.dx.pagopa.it"],
  on .terraform/modules/mcp_registry.portal/custom_domain.tf line 14, in resource "azurerm_cdn_frontdoor_custom_domain" "this":
  14: resource "azurerm_cdn_frontdoor_custom_domain" "this" {

As of March 1, 2025, support for 'TLS10' will be retired from Azure Front
Door, therefore the 'TLS10' property value will be removed in v5.0 of the
provider.

dpulls · 2026-02-06T11:56:20Z

🎉 All dependencies have been resolved !

.github/workflows/release-azure-appsvc-v1.yaml

github-actions · 2026-02-06T12:08:30Z

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..................................(no files to check)Skipped
Terraform Providers Lock (on staged .terraform.lock.hcl files).......................Passed
- hook id: terraform_providers_lock_staged
- duration: 0.09s

No .terraform.lock.hcl files to process.

Terraform fmt........................................................................Passed
terraform_docs on modules............................................................Passed
terraform_docs on resources......................................(no files to check)Skipped
Terraform validate with tflint.......................................................Passed
Terraform validate...................................................................Passed
Terraform validate with trivy........................................................Passed

_{Generated on Fri Feb 6 12:08:28 UTC 2026
Run all checks on modified files}

infra/modules/azure_cdn/tests/integration.tftest.hcl

infra/modules/azure_cdn/custom_domain.tf

infra/modules/azure_cdn/tests/setup/providers.tf

Krusty93 · 2026-02-06T15:52:03Z

infra/modules/azure_cdn/examples/e2e/main.tf

+
+data "azurerm_resource_group" "integration" {
+  name = provider::dx::resource_name(merge(local.naming_config, {
+    name          = "integration",


Suggested change

name = "integration",

name = "e2e",

I know it's not ideal, but to avoid creating two identical CDNs, I leveraged the existing integration one. Do you think it would be better to create a dedicated one for E2E as well?

As discussed in this morning, I believe it'd be better to have two different infrastructures for the two kind of tests. Keep in mind that also foundational infrastructure (vnet, peps, etc.) is also doubled

Krusty93 · 2026-02-06T15:52:13Z

infra/modules/azure_cdn/examples/e2e/main.tf

@@ -0,0 +1,71 @@
+
+data "azurerm_resource_group" "integration" {


Suggested change

data "azurerm_resource_group" "integration" {

data "azurerm_resource_group" "e2e" {

gunzip and others added 20 commits January 27, 2026 14:06

fix: logic, tests and examples

691d091

Apply suggestions from code review

99f9035

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: examples and tests

0b18b2a

fix: Use suggested profile values retrieve, add profile id validation…

3b8e85c

…, add profile SKU check for WAF compatibility

Merge branch 'main' into chores/cdnsec

25cc683

Update infra/modules/azure_cdn/examples/advanced/README.md

73c8f72

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: use parse id function

557cf12

fix: block managed identity config

2275e74

fix: Update documentation

86bbd63

Merge branch 'main' into chores/cdnsec

b983fa4

feat: Remove old tests, use new for contracts, integration, unit and e2e

7e1d1ce

feat: Add CDN for testing in DEV environment

27c2f32

fix: Alternative ruleset name when profile already exist

6d6e67a

Merge branch 'main' into chores/cdnsec

101bfd7

Merge branch 'chores/cdnsec' into feat-add-cdn-tests

cf1a41e

fix: Add e2e example and fix integration test

0ca6f2f

fix: e2e test

487b996

fix: dev lock

6d90aae

Merge branch 'chores/cdnsec' into feat-add-cdn-tests

3609fce

mamu0 had a problem deploying to infra-dev-ci February 3, 2026 08:59 — with GitHub Actions Error

mamu0 temporarily deployed to infra-prod-ci February 3, 2026 09:00 — with GitHub Actions Inactive

mamu0 changed the base branch from main to chores/cdnsec February 3, 2026 09:17

fix: minor

2f1b2a1

Base automatically changed from chores/cdnsec to main February 6, 2026 11:56

Merge branch 'main' into feat-add-cdn-tests

ff26d19

github-advanced-security bot found potential problems Feb 6, 2026

View reviewed changes

.github/workflows/release-azure-appsvc-v1.yaml Fixed Show fixed Hide fixed

mamu0 force-pushed the feat-add-cdn-tests branch from 3918e85 to ff26d19 Compare February 6, 2026 12:07

mamu0 temporarily deployed to infra-dev-ci February 6, 2026 12:07 — with GitHub Actions Inactive

mamu0 marked this pull request as ready for review February 6, 2026 12:29

mamu0 requested a review from a team as a code owner February 6, 2026 12:29

Krusty93 reviewed Feb 6, 2026

View reviewed changes

infra/modules/azure_cdn/tests/integration.tftest.hcl Show resolved Hide resolved

Krusty93 reviewed Feb 6, 2026

View reviewed changes

infra/modules/azure_cdn/custom_domain.tf Show resolved Hide resolved

Krusty93 reviewed Feb 6, 2026

View reviewed changes

infra/modules/azure_cdn/tests/setup/providers.tf Show resolved Hide resolved

Krusty93 reviewed Feb 6, 2026

View reviewed changes

mamu0 requested a review from Krusty93 February 10, 2026 17:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new tests for CDN modules#1283

Add new tests for CDN modules#1283
mamu0 wants to merge 22 commits intomainfrom
feat-add-cdn-tests

mamu0 commented Feb 3, 2026

Uh oh!

changeset-bot bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 3, 2026

✅ All Terraform module locks are up to date

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

dpulls bot commented Feb 6, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Krusty93 Feb 6, 2026

Uh oh!

mamu0 Feb 10, 2026

Uh oh!

Krusty93 Feb 12, 2026

Uh oh!

Krusty93 Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,71 @@

		data "azurerm_resource_group" "integration" {

	data "azurerm_resource_group" "integration" {
	data "azurerm_resource_group" "e2e" {

Conversation

mamu0 commented Feb 3, 2026

Uh oh!

changeset-bot bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Feb 3, 2026

✅ All Terraform module locks are up to date

Uh oh!

github-actions bot commented Feb 3, 2026

📖 Terraform Plan (infra/resources/prod) - success

Uh oh!

dpulls bot commented Feb 6, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Krusty93 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

mamu0 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Krusty93 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Krusty93 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Feb 3, 2026 •

edited

Loading