Skip to content

Add endpoints as storage account output#1304

Merged
gunzip merged 9 commits intomainfrom
fixes/add-storaga-account-queue-endpoint-as-output
Feb 11, 2026
Merged

Add endpoints as storage account output#1304
gunzip merged 9 commits intomainfrom
fixes/add-storaga-account-queue-endpoint-as-output

Conversation

@kin0992
Copy link
Contributor

@kin0992 kin0992 commented Feb 5, 2026

This pull request introduces an enhancement to the output of the storage_account in the infra/modules/azure_function_app/outputs.tf file. The output now includes the primary queue endpoint, which provides easier access to the storage account's queue service endpoint.

That value is necessary to enable RBAC authentication.

Closes CES-1673

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: 60a64ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
azure_function_app Patch
azure_storage_account Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kin0992
Copy link
Contributor Author

kin0992 commented Feb 5, 2026

The changes in this PR are working.

Steps to reproduce:

  1. Go to the storage account linked to the Azure Function (v3)
  2. Navigate to the queue section and select the tasks-queue queue
  3. In case of some errors due to permissions, add the Storage Queue Data Message Sender and Storage Queue Data Reader
  4. Add a message to the queue
  5. Go to Application Insights and after few seconds you will see the QueueTrigger request
Screenshot 2026-02-05 at 18 24 04 6. After that, the queue where you put the message will be empty

@kin0992 kin0992 marked this pull request as ready for review February 5, 2026 17:25
@kin0992 kin0992 requested a review from a team as a code owner February 5, 2026 17:25
@kin0992 kin0992 force-pushed the fixes/add-storaga-account-queue-endpoint-as-output branch from 7d3043c to f302899 Compare February 5, 2026 17:25
@gunzip
Copy link
Contributor

gunzip commented Feb 5, 2026

very good! maybe we should document how to enable RBAC for storages / queues and/or ehnance examples?

@kin0992
Copy link
Contributor Author

kin0992 commented Feb 6, 2026

very good! maybe we should document how to enable RBAC for storages / queues and/or ehnance examples?

@gunzip I updated the changelog.
Is that what you meant?

@gunzip
Copy link
Contributor

gunzip commented Feb 6, 2026

@gunzip I updated the changelog.
Is that what you meant?

Nope :-) I meant to have something in module examples and/or website docs that let AI agents lookup how to setup a storage queue using managed identities.

@kin0992 kin0992 force-pushed the fixes/add-storaga-account-queue-endpoint-as-output branch from 5754087 to 5ea924a Compare February 6, 2026 14:58
@kin0992 kin0992 force-pushed the fixes/add-storaga-account-queue-endpoint-as-output branch from 39fa948 to 56c6fc4 Compare February 6, 2026 16:15
Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! let's see @pagopa/engineering-team-devex

@gunzip gunzip requested a review from a team February 6, 2026 16:28
@kin0992 kin0992 force-pushed the fixes/add-storaga-account-queue-endpoint-as-output branch from 56c6fc4 to 60a64ca Compare February 6, 2026 16:36
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..................................(no files to check)Skipped
Terraform Providers Lock (on staged .terraform.lock.hcl files).......................Passed
- hook id: terraform_providers_lock_staged
- duration: 0.09s

No .terraform.lock.hcl files to process.

Terraform fmt........................................................................Passed
terraform_docs on modules............................................................Passed
terraform_docs on resources......................................(no files to check)Skipped
Terraform validate with tflint.......................................................Passed
Terraform validate...................................................................Passed
Terraform validate with trivy........................................................Passed

Generated on Fri Feb 6 16:37:20 UTC 2026
Run all checks on modified files

@gunzip gunzip merged commit dba6e7b into main Feb 11, 2026
11 checks passed
@gunzip gunzip deleted the fixes/add-storaga-account-queue-endpoint-as-output branch February 11, 2026 10:43
kin0992 added a commit to pagopa/dx-playground that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants