Update Container App module adding support to Functions #974

Krusty93 · 2025-10-06T16:43:36Z

Depends on #961

changeset-bot · 2025-10-06T16:43:40Z

🦋 Changeset detected

Latest commit: 1945d32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
azure_container_app	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

infra/modules/azure_function_app/examples/container_app/main.tf

infra/modules/azure_function_app/alerts.tf

infra/modules/azure_function_app/container_app.tf

Copilot

Pull Request Overview

This PR adds support for Azure Container Apps deployment mode to the existing Azure Function App Terraform module. The module now supports both traditional App Service Plan-based deployments and the newer Container Apps environment approach, allowing users to choose between the two deployment models based on their requirements.

Key changes:

Added a new container_app_config variable to enable Container Apps mode when provided
Implemented conditional resource creation logic to deploy either traditional Function App or Container App based on configuration
Added proper RBAC assignments and networking configurations for Container Apps deployment

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`variables.tf`	Added `container_app_config` variable and updated validation logic for conditional requirements
`tier.tf`	Added CPU and memory mappings for Container Apps resource sizing
`subnets.tf`	Removed standalone subnet resource (moved to networking.tf)
`rbac.tf`	Added conditional RBAC assignments for both deployment modes and Key Vault access
`outputs.tf`	Updated outputs to handle both deployment modes with container_app section
`networking.tf`	Consolidated subnet creation and added conditional private endpoint creation
`main.tf`	Added azapi provider requirement and updated azurerm version constraint
`locals.tf`	Added Container Apps-specific local variables and conditional logic
`function_app_slot.tf`	Updated resource references to use array indexing
`function_app.tf`	Made Function App resource conditional based on deployment mode
`container_app.tf`	New file implementing Azure Container App resource with full configuration
`alerts.tf`	Updated alerts to exclude Container Apps deployment mode
Various example files	Added complete Container Apps deployment example

infra/modules/azure_function_app/main.tf

infra/modules/azure_function_app/container_app.tf

Copilot

Pull Request Overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.

infra/modules/azure_container_app/rbac.tf

infra/modules/azure_container_app/alerts.tf

infra/modules/azure_container_app/examples/function_app/main.tf

gunzip · 2025-10-08T09:22:31Z

infra/modules/azure_container_app/examples/function_app/main.tf

+
+  container_app_environment_id = module.container_app_environment.id
+
+  user_assigned_identity_id = module.container_app_environment.user_assigned_identity.id


question: can we put this setting into the container app module itself? in order to avoid users specify this and just provide the cae

I'm afraid we can't unless we use a data in the module, but it will not be able to create the environment and the app at the same time as there's an nonexistent dependency in the plan phase

lucacavallaro · 2025-10-09T08:04:45Z

infra/modules/azure_container_app/variables.tf

+    action_group_ids                         = optional(set(string), [])
+  })


question: can this reused for other alerts created by the ca module?

.github/workflows/_application_insights_tracking.yaml

+    runs-on: "ubuntu-latest"
+    env:
+      RESOURCE_GROUP_NAME: "dx-d-itn-common-rg-01"
+      INGESTION_ENDPOINT: "https://italynorth-0.in.applicationinsights.azure.com/"
+      INSTRUMENTATION_KEY: "9c95698f-d74e-4046-a555-ea5f632c307e"
+      APPLICATIONINSIGHTS_CONNECTION_STRING: "InstrumentationKey=9c95698f-d74e-4046-a555-ea5f632c307e;IngestionEndpoint=https://italynorth-0.in.applicationinsights.azure.com/;LiveEndpoint=https://italynorth.livediagnostics.monitor.azure.com/;ApplicationId=c6f1af09-fbb3-4770-bf6d-cdaf821d2699"
+
+    steps:
+      # - name: Checkout
+      #   uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.7
+
+      # - name: Configure AZ CLI
+      #   run: |
+      #     az config set extension.use_dynamic_install=yes_without_prompt
+      #     az configure --defaults group="$RESOURCE_GROUP_NAME"
+
+      - name: Node Setup
+        uses: actions/setup-node@v5
+        with:
+          node-version: 24
+
+      - name: Install SDK
+        run: |
+          npm i --save @azure/monitor-opentelemetry @opentelemetry/api
+          npm i --save applicationinsights
+
+      - name: Track event via JS
+        uses: actions/github-script@v8
+        with:
+          script: |
+            // const { useAzureMonitor } = require("@azure/monitor-opentelemetry");
+            //const { trace } = require("@opentelemetry/api");
+            //const { SemanticAttributes } = require("@opentelemetry/semantic-conventions");
+            const appInsights = require("applicationinsights");
+            appInsights.setup(process.env.APPINSIGHTS_CONNECTION_STRING)
+              .setAutoCollectConsole(false)
+              .setAutoCollectExceptions(false)
+              .setAutoCollectDependencies(false)
+              .setAutoCollectRequests(false)
+              .start();
+
+            const client = appInsights.defaultClient;
+            client.trackEvent({ name: "WorkflowStarted" });
+
+            console.log("Tracking event via JS");
+
+            //useAzureMonitor();
+
+            //console.log("Azure monitor setup");
+
+            // const meter =  metrics.getMeter("testMeter");
+            // let counter = meter.createCounter("counter");
+            // counter.add(1, { "testKey": "testValue" });
+
+            // console.log("exception threw");
+
+            // const openTelemetry = ApplicationInsights(
+            // {
+            //   azureMonitorExporterOptions: {
+            //     connectionString: ${{ env.APPLICATIONINSIGHTS_CONNECTION_STRING }},
+            //   }
+            // });
+
+            // const appInsights = new ApplicationInsights({ config: {
+            //   connectionString: '${{ env.APPLICATIONINSIGHTS_CONNECTION_STRING }}',
+            //   /* ...Other Configuration Options... */
+            // } });
+            // appInsights.loadAppInsights();
+
+            // appInsights.trackEvent({ name: 'Open Telemtry', properties: { customProperty: 'custom property value' } });
+            // appInsights.flush();
+
+      - name: Track event
+        run: |
+          echo "logging event to AI"
+
+          curl -X POST ${INGESTION_ENDPOINT}/v2/track \
+            -H "Content-Type: application/json" \
+            -d '[
+              {
+                "ver": 1,
+                "name": ""Microsoft.ApplicationInsights.Metric",
+                "time": "'$(date -u +"%Y-%m-%dT%H:%M:%S.000Z")'",
+                "sampleRate": 100,
+                "iKey": "${{ env.INSTRUMENTATION_KEY }}",
+                "data": {
+                  "baseType": "EventData",
+                  "baseData": {
+                    "ver": 2,
+                    "name": "Workflow completed",
+                    "duration": "00.00:00:10",
+                    "message": "Sample workflow Result",
+                    "properties": {
+                      "job": "build",
+                      "status": "success"
+                    }
+                  }
+                }
+              }
+            ]'


To fix the problem, we should add a permissions block to the workflow to restrict the permissions of the GITHUB_TOKEN. Since this workflow tracks events and does not interact with GitHub resources, contents: read is sufficient and recommended as a minimal starting point. The permissions block should be added either at the top level (applies to all jobs) or under the relevant job (here, tracker). Given only one job is defined, both locations are effective; however, top-level placement is simplest.

Specifically, in .github/workflows/_application_insights_tracking.yaml, insert:

permissions: contents: read

between the name: (line 1) and on: (line 3) lines.

github-actions · 2025-10-13T08:00:33Z

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules......................................................Passed
Terraform Providers Lock (on staged .terraform.lock.hcl files).......................Passed
- hook id: terraform_providers_lock_staged
- duration: 0.05s

No .terraform.lock.hcl files to process.

Terraform fmt........................................................................Passed
terraform_docs on modules............................................................Passed
terraform_docs on resources..........................................................Passed
Terraform validate with tflint.......................................................Passed
Terraform validate...................................................................Passed
Terraform validate with trivy........................................................Passed

_{Generated on Mon Oct 13 08:00:31 UTC 2025
Run all checks on modified files}

dpulls · 2025-10-14T13:05:40Z

🎉 All dependencies have been resolved !

Krusty93 added the priority label Oct 6, 2025

Krusty93 had a problem deploying to infra-dev-ci October 6, 2025 16:43 — with GitHub Actions Failure

mamu0 reviewed Oct 7, 2025

View reviewed changes

infra/modules/azure_function_app/examples/container_app/main.tf Outdated Show resolved Hide resolved

gz-dx-bot reviewed Oct 7, 2025

View reviewed changes

infra/modules/azure_function_app/examples/container_app/main.tf Outdated Show resolved Hide resolved

infra/modules/azure_function_app/examples/container_app/main.tf Outdated Show resolved Hide resolved

infra/modules/azure_function_app/alerts.tf Outdated Show resolved Hide resolved

mamu0 reviewed Oct 7, 2025

View reviewed changes

infra/modules/azure_function_app/container_app.tf Outdated Show resolved Hide resolved

Krusty93 requested a review from Copilot October 7, 2025 07:38

Copilot AI reviewed Oct 7, 2025

View reviewed changes

infra/modules/azure_function_app/main.tf Outdated Show resolved Hide resolved

infra/modules/azure_function_app/main.tf Outdated Show resolved Hide resolved

infra/modules/azure_function_app/container_app.tf Outdated Show resolved Hide resolved

Krusty93 temporarily deployed to infra-dev-ci October 8, 2025 09:00 — with GitHub Actions Inactive

Krusty93 force-pushed the CES-1339-modificare-il-modulo-terraform-per-azure-function-per-supportare-container-app branch from 771baac to 42034d1 Compare October 8, 2025 09:05

Krusty93 requested review from Copilot and mamu0 October 8, 2025 09:05

Krusty93 marked this pull request as ready for review October 8, 2025 09:05

Krusty93 temporarily deployed to infra-dev-ci October 8, 2025 09:05 — with GitHub Actions Inactive

Krusty93 requested a review from a team as a code owner October 8, 2025 09:05

Krusty93 requested a review from gz-dx-bot October 8, 2025 09:05

Copilot AI reviewed Oct 8, 2025

View reviewed changes

infra/modules/azure_container_app/rbac.tf Outdated Show resolved Hide resolved

infra/modules/azure_container_app/alerts.tf Outdated Show resolved Hide resolved

Krusty93 temporarily deployed to infra-dev-ci October 8, 2025 09:10 — with GitHub Actions Inactive

Krusty93 force-pushed the CES-1339-modificare-il-modulo-terraform-per-azure-function-per-supportare-container-app branch from 31cebc2 to d2af60e Compare October 8, 2025 09:11

Krusty93 temporarily deployed to infra-dev-ci October 8, 2025 09:14 — with GitHub Actions Inactive

gunzip reviewed Oct 8, 2025

View reviewed changes

infra/modules/azure_container_app/examples/function_app/main.tf Outdated Show resolved Hide resolved

gunzip reviewed Oct 8, 2025

View reviewed changes

Krusty93 added 4 commits October 8, 2025 11:47

add support to ca

24b9b27

revert function app module changes

e89e23e

add function container app

c44c5ee

update worker process

fcecf0b

Krusty93 temporarily deployed to infra-dev-ci October 8, 2025 09:54 — with GitHub Actions Inactive

Krusty93 temporarily deployed to infra-dev-ci October 8, 2025 13:01 — with GitHub Actions Inactive

wip

f89bbf1

Krusty93 force-pushed the CES-1339-modificare-il-modulo-terraform-per-azure-function-per-supportare-container-app branch from e3d89e3 to f89bbf1 Compare October 8, 2025 13:05

Krusty93 temporarily deployed to infra-dev-ci October 8, 2025 13:06 — with GitHub Actions Inactive

lucacavallaro reviewed Oct 9, 2025

View reviewed changes

Krusty93 changed the title ~~Update Function App module adding support to Function Container App~~ Update Container App module adding support to Functions Oct 9, 2025

Krusty93 requested review from christian-calabrese and removed request for gz-dx-bot October 10, 2025 13:37

add concurrent requests

3d5b845

Krusty93 temporarily deployed to infra-dev-ci October 10, 2025 16:02 — with GitHub Actions Inactive

fixed few things

434d49b

Krusty93 temporarily deployed to infra-dev-ci October 12, 2025 12:39 — with GitHub Actions Inactive

Krusty93 had a problem deploying to infra-dev-ci October 12, 2025 12:39 — with GitHub Actions Failure

Krusty93 had a problem deploying to infra-dev-ci October 12, 2025 12:59 — with GitHub Actions Failure

Krusty93 temporarily deployed to infra-dev-ci October 12, 2025 12:59 — with GitHub Actions Inactive

from number to string

0ffd22a

Krusty93 force-pushed the CES-1339-modificare-il-modulo-terraform-per-azure-function-per-supportare-container-app branch from b934844 to 0ffd22a Compare October 12, 2025 13:03

Krusty93 temporarily deployed to infra-dev-ci October 12, 2025 13:03 — with GitHub Actions Inactive

Krusty93 had a problem deploying to infra-dev-ci October 12, 2025 13:03 — with GitHub Actions Failure

add rg as output

1945d32

Krusty93 had a problem deploying to infra-dev-ci October 13, 2025 07:59 — with GitHub Actions Failure

Krusty93 temporarily deployed to infra-dev-ci October 13, 2025 07:59 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Oct 13, 2025

View reviewed changes

Krusty93 removed the priority label Oct 13, 2025


		container_app_environment_id = module.container_app_environment.id

		user_assigned_identity_id = module.container_app_environment.user_assigned_identity.id

@@ -1,4 +1,6 @@
             name: Tracking Application Insights
+            permissions:
+              contents: read
             on:
               workflow_dispatch:

Update Container App module adding support to Functions #974

Are you sure you want to change the base?

Update Container App module adding support to Functions #974

Uh oh!

Conversation

Krusty93 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gunzip Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Krusty93 Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lucacavallaro Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Check warning

Copilot Autofix

github-actions bot commented Oct 13, 2025

✅ All Terraform module locks are up to date

Uh oh!

dpulls bot commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krusty93 commented Oct 6, 2025 •

edited

Loading

changeset-bot bot commented Oct 6, 2025 •

edited

Loading

Krusty93 Oct 8, 2025 •

edited

Loading