-
Notifications
You must be signed in to change notification settings - Fork 1
Mcp server infrastructure #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: add comments that clarify the purpose of resources
@christian-calabrese if you want, you can merge these changes into the PR with the mcp server code |
bb349c4
to
f1e8f50
Compare
| Name | Version | | ||
|------|---------| | ||
| <a name="provider_azurerm"></a> [azurerm](#provider\_azurerm) | n/a | | ||
| <a name="provider_azurerm"></a> [azurerm](#provider\_azurerm) | 4.47.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There some wrong configuration wrong. Here you're adding the provider version, while in the other readme you're removing it. I believe keeping them is the right one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, there shouldn't be the version here (in local modules) cause providers are inherited from the root module.
I opened a PR to remove this section from modules #1001
Tip ✅ All Terraform module locks are up to dateNo module changes detected - everything is in sync! 📋 Pre-commit Output Log
Generated on Thu Oct 16 16:02:49 UTC 2025 |
Tip ✅ All Terraform module locks are up to dateNo module changes detected - everything is in sync! 📋 Pre-commit Output Log
Generated on Thu Oct 16 16:02:56 UTC 2025 |
Tip ✅ All Terraform module locks are up to dateNo module changes detected - everything is in sync! 📋 Pre-commit Output Log
Generated on Thu Oct 16 16:03:04 UTC 2025 |
📖 Terraform Plan (infra/resources//prod) - successShow Plan # module.dx_website.azurerm_static_web_app_custom_domain.this has changed
~ resource "azurerm_static_web_app_custom_domain" "this" {
id = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-common-rg-01/providers/Microsoft.Web/staticSites/dx-p-itn-website-stapp-01/customDomains/dx.pagopa.it"
- validation_token = (sensitive value) -> null
# (3 unchanged attributes hidden)
}
Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.
─────────────────────────────────────────────────────────────────────────────
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.dx_website.azurerm_dns_txt_record.validation will be updated in-place
~ resource "azurerm_dns_txt_record" "validation" {
id = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-network-rg-01/providers/Microsoft.Network/dnsZones/dx.pagopa.it/TXT/_dnsauth.dx.pagopa.it"
name = "_dnsauth.dx.pagopa.it"
tags = {}
# (4 unchanged attributes hidden)
- record {
# At least one attribute in this block is (or was) sensitive,
# so its contents will not be displayed.
}
+ record {
# At least one attribute in this block is (or was) sensitive,
# so its contents will not be displayed.
}
}
# module.dx_website.azurerm_static_web_app.this will be updated in-place
~ resource "azurerm_static_web_app" "this" {
id = "/subscriptions/02a23258-2e41-433c-8e9a-465b99e77bca/resourceGroups/dx-p-itn-common-rg-01/providers/Microsoft.Web/staticSites/dx-p-itn-website-stapp-01"
name = "dx-p-itn-website-stapp-01"
- repository_branch = "main" -> null
- repository_url = "https://github.com/pagopa/dx" -> null
~ sku_tier = "Standard" -> "Free"
tags = {
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "Developer Experience"
"Owner" = "DevEx"
"Source" = "https://github.com/pagopa/dx/blob/main/infra/resources/prod"
}
# (10 unchanged attributes hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. |
📖 Terraform Plan (infra/resources//dev) - successShow Plan # module.mcp_server.aws_lambda_function.server will be updated in-place
~ resource "aws_lambda_function" "server" {
id = "dx-p-euc1-mcp-server-lambda-01"
tags = {
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "Developer Experience"
"Owner" = "DevEx"
"Source" = "https://github.com/pagopa/dx/blob/main/infra/resources/dev"
}
# (28 unchanged attributes hidden)
~ environment {
~ variables = {
- "LOG_LEVEL" = "debug" -> null
# (1 unchanged element hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.testing.azurerm_subnet_network_security_group_association.common_runner_to_tests_pep["/subscriptions/35e6e3b2-4388-470e-a1b9-ad3bc34326d1/resourceGroups/dx-d-itn-network-rg-01/providers/Microsoft.Network/virtualNetworks/dx-d-itn-common-vnet-01/subnets/dx-d-itn-modules-test-cae-snet-02"] will be created
+ resource "azurerm_subnet_network_security_group_association" "common_runner_to_tests_pep" {
+ id = (known after apply)
+ network_security_group_id = "/subscriptions/35e6e3b2-4388-470e-a1b9-ad3bc34326d1/resourceGroups/dx-d-itn-network-rg-01/providers/Microsoft.Network/networkSecurityGroups/dx-d-itn-common-vnet-nsg-01"
+ subnet_id = "/subscriptions/35e6e3b2-4388-470e-a1b9-ad3bc34326d1/resourceGroups/dx-d-itn-network-rg-01/providers/Microsoft.Network/virtualNetworks/dx-d-itn-common-vnet-01/subnets/dx-d-itn-modules-test-cae-snet-02"
}
Plan: 1 to add, 1 to change, 0 to destroy.
Warning: Reference to undefined provider
on aws.tf line 11, in module "mcp_server":
11: aws = aws.eu-central-1
There is no explicit declaration for local provider name "aws" in
module.mcp_server, so Terraform is assuming you mean to pass a configuration
for "hashicorp/aws".
If you also control the child module, add a required_providers entry named
"aws" with the source address "hashicorp/aws".
(and 2 more similar warnings elsewhere) |
This PR implements the infrastructure needed to expose the PoC of the DX MCP Server
The terraform changes have already been applied to verify they're working correctly. The MCP server is already reachable here: https://api.dev.dx.pagopa.it/mcp