Skip to content

Conversation

christian-calabrese
Copy link
Contributor

Resolves CES-1330

@christian-calabrese christian-calabrese requested a review from a team as a code owner October 15, 2025 10:21
Copy link

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: 84d0e1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.86%. Comparing base (8abeb56) to head (8534a7c).
⚠️ Report is 109 commits behind head on main.

❌ Your project status has failed because the head coverage (45.86%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #992       +/-   ##
===========================================
- Coverage   67.85%   45.86%   -22.00%     
===========================================
  Files          31       49       +18     
  Lines         840     1969     +1129     
  Branches      146      222       +76     
===========================================
+ Hits          570      903      +333     
- Misses        258     1047      +789     
- Partials       12       19        +7     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net

Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the whole TypeScript example (and any reference to TypeScript) and leave only the Terraform HCL part.

@gunzip
Copy link
Contributor

gunzip commented Oct 15, 2025

What about turning this into a guide to use EventGrid triggers instead of migrating them?

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds documentation guiding migration from Azure Functions Blob Trigger to EventGrid to improve scalability and efficiency (CES-1330).

  • New architecting section index with link to EventGrid vs Blob trigger guide.
  • Comprehensive migration guide including code samples and Terraform configuration.
  • Changeset entry to publish docs update.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
apps/website/docs/azure/architecting/index.md Introduces architecting section and links to new EventGrid migration guide.
apps/website/docs/azure/architecting/eventgrid-storage-functions.md Provides detailed migration steps, code samples, Terraform snippets, and best practices.
.changeset/purple-melons-see.md Registers a patch-level docs update for release.

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net

Comment on lines +119 to +129
{
"bindings": [
{
"type": "eventGridTrigger",
"name": "eventGridEvent",
"direction": "in"
}
],
"scriptFile": "../dist/main.js",
"entryPoint": "onBlobEventEntryPoint"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


included_event_types = ["Microsoft.Storage.BlobCreated"]

subject_filter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I'd add comments to distinguish mandatory vs optional fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants