-
Notifications
You must be signed in to change notification settings - Fork 1
Document storage account eventgrid trigger #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Document storage account eventgrid trigger #992
Conversation
🦋 Changeset detectedLatest commit: 84d0e1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (45.86%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
===========================================
- Coverage 67.85% 45.86% -22.00%
===========================================
Files 31 49 +18
Lines 840 1969 +1129
Branches 146 222 +76
===========================================
+ Hits 570 903 +333
- Misses 258 1047 +789
- Partials 12 19 +7 🚀 New features to boost your workflow:
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the whole TypeScript example (and any reference to TypeScript) and leave only the Terraform HCL part.
apps/website/docs/azure/integrating-services/eventgrid-storage-functions.md
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
What about turning this into a guide to use EventGrid triggers instead of migrating them? |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds documentation guiding migration from Azure Functions Blob Trigger to EventGrid to improve scalability and efficiency (CES-1330).
- New architecting section index with link to EventGrid vs Blob trigger guide.
- Comprehensive migration guide including code samples and Terraform configuration.
- Changeset entry to publish docs update.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
apps/website/docs/azure/architecting/index.md | Introduces architecting section and links to new EventGrid migration guide. |
apps/website/docs/azure/architecting/eventgrid-storage-functions.md | Provides detailed migration steps, code samples, Terraform snippets, and best practices. |
.changeset/purple-melons-see.md | Registers a patch-level docs update for release. |
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
apps/website/docs/azure/integrating-services/eventgrid-storage-functions.md
Show resolved
Hide resolved
apps/website/docs/azure/architecting/eventgrid-storage-functions.md
Outdated
Show resolved
Hide resolved
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-mud-0405c6703-992.westeurope.1.azurestaticapps.net |
{ | ||
"bindings": [ | ||
{ | ||
"type": "eventGridTrigger", | ||
"name": "eventGridEvent", | ||
"direction": "in" | ||
} | ||
], | ||
"scriptFile": "../dist/main.js", | ||
"entryPoint": "onBlobEventEntryPoint" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: this configuration is deprecated, the correct example is something like this:
|
||
included_event_types = ["Microsoft.Storage.BlobCreated"] | ||
|
||
subject_filter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I'd add comments to distinguish mandatory vs optional fields
Resolves CES-1330