Skip to content

[#HSL-4] E2E tests for access logs on Azure Storage#58

Open
balanza wants to merge 6 commits intomasterfrom
hsl-4--e2e-tests-for-azure-storage
Open

[#HSL-4] E2E tests for access logs on Azure Storage#58
balanza wants to merge 6 commits intomasterfrom
hsl-4--e2e-tests-for-azure-storage

Conversation

@balanza
Copy link
Contributor

@balanza balanza commented Jun 20, 2022

This PR introduces a test scenario that does the following:

  • Start the application with an Azure Storage account attached and ENABLE_SPID_ACCESS_LOGS=true
  • Run a successful login
  • Query storage to check if a log is present

Request content isn't inspected

Caveats

  • From an E2E perspective, we can't relate a log to a specific login session; thus, tests are dummy and only check for log presence. For finer-grained tests, the check must be improved.

Changes

See commit list

⚠️ Tests aren't currently working due to issues with Azurite.

The following error arise at writing time. The error is not present when tests are executed against a real instance of Azure Storage

StorageError: Server failed to authenticate the request. Make sure the value of the Authorization header is formed correctly including the signature

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Jun 20, 2022

Warnings
⚠️ This PR changes a total of 5089 LOCs, that is more than a reasonable size of 250. Consider splitting the pull request into smaller ones.
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

azure-storage

Used in e2e/package.json
Author: Microsoft Corporation Description: Microsoft Azure Storage Client Library for Node.js
License: Apache-2.0 Homepage: http://github.com/Azure/azure-storage-node
Keywords: node, azure and storage
Updated: 8 days ago Created: about 8 years ago
Releases: 50 Maintainers: 2
Direct Dependencies: browserify-mime, extend, json-edm-parser, md5.js, readable-stream, request, underscore, uuid, validator, xml2js, xmlbuilder, json-schema
README

Legacy Azure Storage SDK for JavaScript

NPM version Build Status Coverage Status

This project provides the legacy Node.js package azure-storage which is browser compatible to consume and manage Microsoft Azure Storage Services like Azure Blob Storage, Azure Queue Storage, Azure Files and Azure Table Storage

Please note, newer packages @azure/storage-blob, @azure/storage-queue and @azure/storage-file are available as of November 2019 and @azure/data-tables is available as of June 2021 for the individual services. While the legacy azure-storage package will continue to receive critical bug fixes, we strongly encourage you to upgrade.

Below are a set of links with information on both the latest and legacy packages for the different Storage services from Azure. For more, please read State of the Azure SDK 2021

Package Version Description API Reference Links Migration Guide Links
@azure/storage-blob v12 The next generation SDK for Azure Blob Storage API Reference for Blob SDK Migration Guide from azure-storage to @azure/storage-blob
@azure/storage-queue v12 The next generation SDK for Azure Queue Storage API Reference for Queues SDK Migration Guide from azure-storage to @azure/storage-queue
@azure/storage-file-share v12 The next generation SDK for Azure Files API Reference for Files SDK Migration Guide from azure-storage to @azure/storage-file-share
@azure/data-tables v12 The next generation SDK for Azure Table Storage API Reference for Tables SDK Migration Guide from azure-storage to @azure/data-tables
azure-storage v2 Legacy Storage SDK in this repository (Blob/Queue/File/Table, callback style) API Reference for legacy Storage SDK
@azure/arm-storage v7 & above Management SDKs including Storage Resource Provider APIs API Reference for Storage Management SDK

New dependencies added: azure-storage.

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 91d95db

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants