Skip to content

fix: no role checks #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
v1tt0ri0Alt wants to merge 4 commits into
base: develop
Choose a base branch
from
+113 −48

added tests for coverage

ca81603
Select commit
Loading
Failed to load commit list.
Draft

fix: no role checks #305

added tests for coverage
ca81603
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 11, 2025 in 36s

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 620 in src/main/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=pagopa_idpay-transactions&issues=AZsOC2e-vdfbJeZ_GnUP&open=AZsOC2e-vdfbJeZ_GnUP&pullRequest=305

Check warning on line 1714 in src/test/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=pagopa_idpay-transactions&issues=AZsOC2bUvdfbJeZ_GnUN&open=AZsOC2bUvdfbJeZ_GnUN&pullRequest=305

Check warning on line 1810 in src/test/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "validateRewardBatch_InvalidState" on line 1733. 

See more on https://sonarcloud.io/project/issues?id=pagopa_idpay-transactions&issues=AZsONVuVmFVxrVg-dI6I&open=AZsONVuVmFVxrVg-dI6I&pullRequest=305

Check warning on line 1672 in src/test/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=pagopa_idpay-transactions&issues=AZsOC2bUvdfbJeZ_GnUM&open=AZsOC2bUvdfbJeZ_GnUM&pullRequest=305

Check warning on line 631 in src/main/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=pagopa_idpay-transactions&issues=AZsOC2e-vdfbJeZ_GnUQ&open=AZsOC2e-vdfbJeZ_GnUQ&pullRequest=305

Check warning on line 39 in src/main/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=pagopa_idpay-transactions&issues=AZsOC2e-vdfbJeZ_GnUO&open=AZsOC2e-vdfbJeZ_GnUO&pullRequest=305
View more details on SonarQubeCloud