PIN-5572 DescriptorVersion from string to number#1688
Merged
rGregnanin merged 41 commits intodevelopfrom Jul 11, 2025
Merged
Conversation
rGregnanin
requested review from
AsterITA,
Carminepo2,
beetlecrunch,
galales and
taglioni-r
as code owners
taglioni-r
reviewed
Mar 27, 2025
ecamellini
reviewed
Mar 28, 2025
taglioni-r
reviewed
Apr 3, 2025
Contributor
There was a problem hiding this comment.
I agree with the change here. I am not sure about the change in bffApi and apiAgatewayApi (cc @galales)
Also, frontend should be involved if changing bffApi (cc @Carminepo2)
Collaborator
|
@rGregnanin 👋 This seems to have enough approval to be merged, is it missing something? |
galales
approved these changes
Jun 23, 2025
ecamellini
reviewed
Jul 10, 2025
Comment on lines
6084
to
6086
| version: | ||
| type: string | ||
| type: integer | ||
| format: int32 |
Collaborator
There was a problem hiding this comment.
Since this is now in production, we need to understand if it can be considered a breaking change or not, cc @galales
Contributor
There was a problem hiding this comment.
we cannot create a breaking in this case, let's keep it as string and open a task to change it on the next major
Collaborator
There was a problem hiding this comment.
Tracked here: https://pagopa.atlassian.net/browse/PIN-7225
ecamellini
approved these changes
Jul 10, 2025
rGregnanin
deleted the
PIN-5572_chenge_descriptorVersion_from_string_to_number
branch
rGregnanin
added a commit
that referenced
this pull request
Jul 14, 2025
This reverts commit 8e3763b.
rGregnanin
restored the
PIN-5572_chenge_descriptorVersion_from_string_to_number
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.