Skip to content

PIN-6656 M2M - Reject consumer delegation #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 3, 2025
Merged

PIN-6656 M2M - Reject consumer delegation #1839

merged 9 commits into from
May 3, 2025

Conversation

ecamellini
Copy link
Collaborator

@ecamellini ecamellini commented Apr 28, 2025 •
edited
Loading

Description

POST /consumerDelegations/{delegationId}/reject

Double-check errors

  • Check errors returned by the process API calls (messages should be meaningful, clean, in correct English, etc.)
  • Check spec errors: it should list all non-500 errors, also the ones that pass through from the process

Testing

Checklist:

  • Bruno call added to collection
  • Smoke test Bruno (attach result screenshot)
  • Supertest /api tests
  • /integration tests for the logic in the service

Bruno smoke test

image image

Testing some passthrough errors

image image

@ecamellini ecamellini changed the base branch from develop to PIN-6629-m2m-gateway-delegations-routes April 28, 2025 15:06
@ecamellini ecamellini marked this pull request as ready for review April 28, 2025 15:31
@ecamellini ecamellini requested review from zerbiniandrea and removed request for AsterITA, beetlecrunch, galales and taglioni-r April 28, 2025 15:32
@ecamellini ecamellini merged commit 04dfb70 into PIN-6629-m2m-gateway-delegations-routes May 3, 2025
5 checks passed
@ecamellini ecamellini deleted the PIN-6656-m2m-reject-consumer-delegation branch May 3, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerbiniandrea zerbiniandrea zerbiniandrea approved these changes

@Carminepo2 Carminepo2 Carminepo2 approved these changes

Assignees
No one assigned
Labels
api-v2 delegation-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecamellini @zerbiniandrea @Carminepo2