PIN-7683 add notification to listing queries #2383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrotaje
commented
Sep 18, 2025
sandrotaje
force-pushed
the
PIN-7683_add-notification-to-listing-queries
branch
from
efaeb83 to
0ff7e2e
Compare
sandrotaje
changed the base branch from
develop
to
PIN-7605_count_notification_by_type
Base automatically changed from
PIN-7605_count_notification_by_type
to
develop
September 29, 2025 10:30
sandrotaje
force-pushed
the
PIN-7683_add-notification-to-listing-queries
branch
from
0ff7e2e to
225d61a
Compare
Carminepo2
approved these changes
Oct 1, 2025
taglioni-r
approved these changes
Oct 1, 2025
GorlemZ
force-pushed
the
PIN-7683_add-notification-to-listing-queries
branch
6 times, most recently
from
af2d708 to
c169842
Compare
sandrotaje
commented
Oct 7, 2025
sandrotaje
commented
Oct 7, 2025
packages/in-app-notification-manager/src/routers/notificationRouter.ts
Outdated
Show resolved
Hide resolved
sandrotaje
commented
Oct 7, 2025
packages/in-app-notification-manager/test/api/filterUnreadNotifications.test.ts
Outdated
Show resolved
Hide resolved
GorlemZ
force-pushed
the
PIN-7683_add-notification-to-listing-queries
branch
2 times, most recently
from
7348eb2 to
7e0e78e
Compare
sandrotaje
force-pushed
the
PIN-7683_add-notification-to-listing-queries
branch
3 times, most recently
from
48b29d4 to
bd72ff0
Compare
sandrotaje
changed the base branch from
develop
to
PIN-7806_switch25-clientkey-and-producerkeychain
GorlemZ
force-pushed
the
PIN-7683_add-notification-to-listing-queries
branch
2 times, most recently
from
4e03ec6 to
c802389
Compare
packages/in-app-notification-manager/test/api/filterUnreadNotifications.test.ts
Outdated
Show resolved
Hide resolved
packages/in-app-notification-manager/test/api/filterUnreadNotifications.test.ts
Show resolved
Hide resolved
packages/in-app-notification-manager/test/integration/filterUnreadNotifications.test.ts
Show resolved
Hide resolved
packages/backend-for-frontend/src/api/eserviceTemplateApiConverter.ts
Outdated
Show resolved
Hide resolved
Base automatically changed from
PIN-7806_switch25-clientkey-and-producerkeychain
to
develop
October 14, 2025 12:41
tpetrucciani
approved these changes
Oct 15, 2025
sandrotaje
force-pushed
the
PIN-7683_add-notification-to-listing-queries
branch
from
b29dcda to
64693c5
Compare
sandrotaje
requested review from
beetlecrunch,
galales,
lorenzo-pa and
paolomanca-pagopa
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
hasUnreadNotificationsfield to every needed listing query so that the FE could show a dot if that entity ha a an unread notification.Useful mapping between the FE listing pages and the BFF endpoints called to retrieve the data lists: