feature: avoid duplicate M2M event writes (PIN-7824) #2454
+313
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
requested review from
Carminepo2,
beetlecrunch,
galales,
lorenzo-pa,
paolomanca-pagopa and
taglioni-r
as code owners
taglioni-r
approved these changes
Oct 7, 2025
…ture/PIN-7824_avoid-duplicate-event-writes
Base automatically changed from
feature/PIN-7853_writing-agreement-m2m-events
to
develop
October 8, 2025 14:45
galales
reviewed
Oct 16, 2025
| await insertIfVersionNotPresent( | ||
| event, | ||
| eserviceInM2MEvent, | ||
| eq(eserviceInM2MEvent.eserviceId, event.eserviceId) |
There was a problem hiding this comment.
should the filter include the resourceVersion?
If I'm not missing something, this limit may take a different resource version, despite the existence of the current event
| await insertIfVersionNotPresent( | ||
| event, | ||
| agreementInM2MEvent, | ||
| eq(agreementInM2MEvent.agreementId, event.agreementId) |
| await insertIfVersionNotPresent( | ||
| event, | ||
| attributeInM2MEvent, | ||
| eq(attributeInM2MEvent.attributeId, event.attributeId) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PIN-7824
Impacted Services
m2m-event-dispatcherTests
Added automated tests, working ✅