feature: Add EserviceIds and States filters to GET /clients/{clientId}/purposes (PIN-7672) #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
reviewed
Oct 7, 2025
Comment on lines
+164
to
+173
| - in: query | ||
| name: purposesIds | ||
| description: comma separated sequence of purposes IDs | ||
| schema: | ||
| type: array | ||
| items: | ||
| type: string | ||
| format: uuid | ||
| default: [] | ||
| explode: false |
There was a problem hiding this comment.
Looking at the PR, I just remembered why we had a call for each purpose instead of a filter like this one on the listing - more details in this task we opened about this issue in the API V2 the board: PIN-7204
Maybe we could verify if the issue is still reproducible, then decide what to do - I would ask more details to @galales, who opened the task for this feature, and also pointed out this issue in the first place when we were implementing this call
PGDeve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Context
New query parameters for GET /clients/{clientId}/purposes API v2:
eservicesIds: list of eserviceId to filter the list of purposes (see issue 1398).states: list of states to filter the list of purposes based on current version state (see issues 1421).Moved from
n(i.e. the number of purposes linked to a specific client) GET /purposes/{id} calls, to a single GET /purposes with the newpurposesIdsquery parameter.Impacted Services
Manual Tests
Tests on 4 purposes linked to client
ce703dc9-f511-4e1e-8655-cf7744229d31and 2 e-services. One of those is archived.No filters
EservicesIds
States
Client with no Purposes