Skip to content

Pin 7819 post eservice template versions #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: release/2.8.0
Choose a base branch
from
Open

Pin 7819 post eservice template versions #2461

wants to merge 13 commits into from
+8,255 −332

Conversation

crasherbit
Copy link
Collaborator

@crasherbit crasherbit commented Oct 7, 2025 •
edited by atlassian bot
Loading

PIN-7819
PIN-7900

SRS

Description

Implemented POST /eserviceTemplates/{templateId}/versions/ route in m2m gateway

Implementation

  • Finalize SRS
  • JIRA task link in PR, with link to SRS
  • API spec of the route in m2mGatewayApi.yml
  • Documentation: description fields in the spec endpoint, response, errors, params, etc.

Double-check errors

  • Check errors returned by the process API calls (messages should be meaningful, clean, in correct English, etc.)
  • Check spec errors: it should list all non-500 errors, also the ones that pass through from the process

Testing

Checklist:

  • Bruno call added to collection
  • Smoke test Bruno (attach result screenshot)
  • Supertest /api tests
  • /integration tests for the logic in the service

Screen

POST

@crasherbit crasherbit marked this pull request as ready for review October 8, 2025 09:15
Crasherbit added 2 commits October 9, 2025 12:37
@crasherbit crasherbit force-pushed the PIN-7819_POST_eserviceTemplateVersions branch from 57ff2ef to e332158 Compare October 9, 2025 10:38
ecamellini
ecamellini requested changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@ecamellini ecamellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation differs from the corresponding descriptor creation calls, both in the M2M and in the process/BFF.

@ecamellini ecamellini mentioned this pull request Oct 10, 2025
Closed
10 tasks
ecamellini
ecamellini approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@ecamellini ecamellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀 Only minor suggestions and some tests seem to be missing (quick fixes)

@crasherbit crasherbit changed the base branch from develop to release/2.8.0 October 16, 2025 09:06
@ecamellini
Copy link
Collaborator

Diff now contains a lot of unrelated changes, let's wait for release/2.8.0 to be up-to-date with develop, then it should be solved (this PR was probably detached from dev after the release branch?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecamellini ecamellini ecamellini approved these changes

@beetlecrunch beetlecrunch Awaiting requested review from beetlecrunch beetlecrunch is a code owner

@galales galales Awaiting requested review from galales galales is a code owner

@Carminepo2 Carminepo2 Awaiting requested review from Carminepo2 Carminepo2 is a code owner

@taglioni-r taglioni-r Awaiting requested review from taglioni-r taglioni-r is a code owner

@lorenzo-pa lorenzo-pa Awaiting requested review from lorenzo-pa lorenzo-pa is a code owner

@paolomanca-pagopa paolomanca-pagopa Awaiting requested review from paolomanca-pagopa paolomanca-pagopa is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

api-v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crasherbit @ecamellini @sandrotaje @diego-lon