-
Notifications
You must be signed in to change notification settings - Fork 2
PIN-7882 add blocklist notification types #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sandrotaje
wants to merge
18
commits into
PIN-7639_restrict_notifications_by_user_role
Choose a base branch
from
PIN-7882_add-blocklist-notification-types
base: PIN-7639_restrict_notifications_by_user_role
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PIN-7882 add blocklist notification types #2466
sandrotaje
wants to merge
18
commits into
PIN-7639_restrict_notifications_by_user_role
from
PIN-7882_add-blocklist-notification-types
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carminepo2
approved these changes
Oct 9, 2025
paolomanca-pagopa
approved these changes
Oct 10, 2025
fbee4d0
to
a87579b
Compare
6632b17
to
0d1f526
Compare
e294380
to
bce9a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional ENV VAR. The NOTIFICATION_TYPE_BLOCKLIST env var is a comma separeted list of notification types that we want to disable.
Initially, this feature will be used to perform a progressive rollout, but in the future, it could be used to temporarily block some notification type for some unknown problem