PIN-7887 add user email resolution through SelfCare API in email sender #2474
+1,333
−517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetrucciani
reviewed
Oct 9, 2025
Comment on lines
+66
to
+79
| if (resp.length > 1) { | ||
| loggerInstance.error( | ||
| `Multiple users (${resp.length}) found in Selfcare for userId ${userId} and tenant ${tenantId}` | ||
| ); | ||
| return undefined; | ||
| } | ||
|
|
||
| const email = resp[0].email; | ||
| if (!email) { | ||
| loggerInstance.error( | ||
| `User ${userId} in tenant ${tenantId} has no email in Selfcare` | ||
| ); | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
👍 I agree with the error handling choices
The only issue could be that, for the logger.error + discard cases, if they occur because of a Selfcare API change that affects all users, we could discard many notifications before we realize the error. However, if they occur for individual users (due to dirty data in the Selfcare source of truth), this approach is best to avoid stopping sending emails entirely. That seems to me the most likely case in which this occurs, so I think it makes sense to treat them as done here. In the less likely scenario of an uncommunicated API schema change, we could always reprocess the events to resend the discarded notifications
sandrotaje
requested review from
Carminepo2,
beetlecrunch,
galales,
lorenzo-pa,
paolomanca-pagopa and
taglioni-r
as code owners
tpetrucciani
approved these changes
Oct 14, 2025
taglioni-r
approved these changes
Oct 15, 2025
…entToEmailPayload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.