PIN-7516 GET /eservices/{eServiceId}/descriptors/{descriptorId}/(certified,verified,declared)Attributes

[rGregnanin]

PIN-7516

SRS

Description

Implemented GET /eservices/{eServiceId}/descriptors/{descriptorId}/(certified,verified,declared)Attributes routes in m2m gateway

Implementation

• Finalize SRS
• JIRA task link in PR, with link to SRS
• API spec of the route in m2mGatewayApi.yml
• Documentation: description fields in the spec endpoint, response, errors, params, etc.

Double-check errors

• Check errors returned by the process API calls (messages should be meaningful, clean, in correct English, etc.)
• Check spec errors: it should list all non-500 errors, also the ones that pass through from the process

Testing

Checklist:

• Bruno call added to collection
• Smoke test Bruno (attach result screenshot)
• Supertest /api tests
• /integration tests for the logic in the service

[ecamellini]

Implementation looks good 🚀
I think the code is clear enough to remove most of the comments. I would add comments only to explain the reason for a step that is not already straightforward with variable/function names

[ecamellini]

Align also with @crasherbit since part of this implementation could be extracted into a utility function to also create the returning value of the POST calls, since they return the same object.

[ecamellini]

Looks good 🚀
But there's a bug in the totalCount computation ⚠️
Plus, left some minor suggestions/quick fixes

[ecamellini]

Super!

[galales]

minor change required, but spec LG

[galales]

if an attribute id exists in a descriptor and this attribute is not found in the registry, it is considered an internal error

Suggested change

"eserviceDescriptorAttributeNotFound",

[ecamellini]

Something wrong with the new base branch, since I see a lot of unrelated changes! It's because it was based on develop where more stuff was merged after the release branch was created...

Maybe the simplest thing to do is to merge develop again in release/2.8.0, it shouldn't be an issue. Otherwise, you need to re-apply only the changes related to this feature and it's not straightforward