hotfix: add error to GET /backend-for-frontend/tenants/{tenants-id}/users (PIN-7759)
#2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuyec
commented
Oct 13, 2025
Comment on lines
+252
to
+253
| throw unauthorizedError( | ||
| `Requester ${requesterId} cannot retrieve users for tenant ${tenantId}` |
There was a problem hiding this comment.
unauthorizedError is already mapped to HTTP_STATUS_FORBIDDEN by default, so there is no need to update the error mappers
shuyec
requested review from
Carminepo2,
beetlecrunch,
galales,
lorenzo-pa,
paolomanca-pagopa and
taglioni-r
as code owners
paolomanca-pagopa
approved these changes
Oct 13, 2025
shuyec
changed the title
/backend-for-frontend/tenants/{tenants-id}/users (PIN-7759)GET /backend-for-frontend/tenants/{tenants-id}/users (PIN-7759)
taglioni-r
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Context / Why
This PR adds a check to the GET
/backend-for-frontend/tenants/{tenants-id}/users. If a requester tries to get the users list of another tenant, then it gets an error 403.Impacted services
Checklist