PIN-7916 add personal data filter #2485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation for personalData
eduwardo
requested review from
Carminepo2,
beetlecrunch,
galales,
lorenzo-pa and
paolomanca-pagopa
as code owners
shuyec
approved these changes
Oct 15, 2025
packages/backend-for-frontend/test/api/catalogRouter/getCatalog.test.ts
Outdated
Show resolved
Hide resolved
...ges/backend-for-frontend/test/api/eserviceTemplateRouter/getCatalogEServiceTemplates.test.ts
Outdated
Show resolved
Hide resolved
packages/eservice-template-process/test/api/getEServiceTemplates.test.ts
Outdated
Show resolved
Hide resolved
…getCatalogEServiceTemplates.test.ts Co-authored-by: shuyec <[email protected]>
…g.test.ts Co-authored-by: shuyec <[email protected]>
…es.test.ts Co-authored-by: shuyec <[email protected]>
| ); | ||
| }); | ||
|
|
||
| it.each([true, false])( |
There was a problem hiding this comment.
Is there a test where you check for undefined and return all results?
There was a problem hiding this comment.
Since there's already a test for the /eservices endpoint without query parameters, the undefined case is already implicitly covered, so adding it here would be redundant.
paolomanca-pagopa
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR os for adding the personalData filter in
getEservicesandgetEserviceTemplates