Skip to content

vapt/PIN-6349: missing-integrity-attribute for templates #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

vapt/PIN-6349: missing-integrity-attribute for templates #2486

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5925ccc
refactor: add integrity and removed useless style import
sandrotaje Oct 14, 2025
e407a62
fix: remove duplicate empty media query blocks from email templates
sandrotaje Oct 17, 2025
3d93689
Merge branch 'develop' into vapt/PIN-6349-missing-integrity-attribute
sandrotaje Oct 17, 2025
ac6ce67
Merge branch 'develop' into vapt/PIN-6349-missing-integrity-attribute
sandrotaje Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/email-notification-dispatcher/src/resources/templates/headers/common-header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,11 @@
<![endif]-->
<!--[if !mso]><!-->
<link
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
rel="stylesheet"
type="text/css"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) { .mj-column-per-100 { width: 100%
Expand Down
10 changes: 6 additions & 4 deletions packages/notification-email-sender/src/resources/templates/agreement-activated-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
</style>
<![endif]-->
<!--[if !mso]><!-->
<link href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css" rel="stylesheet" type="text/css">
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
<link
rel="stylesheet"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) {
Expand Down
10 changes: 6 additions & 4 deletions packages/notification-email-sender/src/resources/templates/agreement-rejected-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
</style>
<![endif]-->
<!--[if !mso]><!-->
<link href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css" rel="stylesheet" type="text/css">
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
Comment on lines -61 to -63
Copy link
Collaborator Author

@sandrotaje sandrotaje Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in all templates since it is a duplicate and do not allow integrity property

<link
rel="stylesheet"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) {
Expand Down
10 changes: 6 additions & 4 deletions packages/notification-email-sender/src/resources/templates/agreement-submitted-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
</style>
<![endif]-->
<!--[if !mso]><!-->
<link href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css" rel="stylesheet" type="text/css">
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
<link
rel="stylesheet"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) {
Expand Down
10 changes: 6 additions & 4 deletions ...notification-email-sender/src/resources/templates/eservice-descriptor-published-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
</style>
<![endif]-->
<!--[if !mso]><!-->
<link href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css" rel="stylesheet" type="text/css">
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
<link
rel="stylesheet"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) {
Expand Down
8 changes: 5 additions & 3 deletions ...otification-email-sender/src/resources/templates/first-purpose-version-rejected-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,14 @@
<![endif]-->
<!--[if !mso]><!-->
<link
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
rel="stylesheet"
type="text/css"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
@media only screen and (min-width: 480px) {
</style>
<!--<![endif]-->
<style type="text/css">
Expand Down
10 changes: 6 additions & 4 deletions ...n-email-sender/src/resources/templates/new-purpose-version-waiting-for-approval-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
</style>
<![endif]-->
<!--[if !mso]><!-->
<link href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css" rel="stylesheet" type="text/css">
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
<link
rel="stylesheet"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) {
Expand Down
8 changes: 5 additions & 3 deletions ...otification-email-sender/src/resources/templates/other-purpose-version-rejected-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,14 @@
<![endif]-->
<!--[if !mso]><!-->
<link
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
rel="stylesheet"
type="text/css"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
@media only screen and (min-width: 480px) {
</style>
<!--<![endif]-->
<style type="text/css">
Expand Down
10 changes: 6 additions & 4 deletions ...ges/notification-email-sender/src/resources/templates/purpose-version-activated-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
</style>
<![endif]-->
<!--[if !mso]><!-->
<link href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css" rel="stylesheet" type="text/css">
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
<link
rel="stylesheet"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) {
Expand Down
10 changes: 6 additions & 4 deletions .../notification-email-sender/src/resources/templates/purpose-waiting-for-approval-mail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
</style>
<![endif]-->
<!--[if !mso]><!-->
<link href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css" rel="stylesheet" type="text/css">
<style type="text/css">
@import url(https://selfcare.pagopa.it/assets/font/selfhostedfonts.css);
</style>
<link
rel="stylesheet"
href="https://selfcare.pagopa.it/assets/font/selfhostedfonts.css"
integrity="sha384-pTEX27xRwV9gE3zi2iAdapYn6pEZ+f//cYR7Wm31DbTWyxHmn8eVK+BIz6vMb70r"
crossorigin="anonymous"
/>
<!--<![endif]-->
<style type="text/css">
@media only screen and (min-width:480px) {
Expand Down
Loading