Skip to content

feat: dynamic timeout computation with optional input timeout #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: dynamic timeout computation with optional input timeout #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/deploy-sub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
type: string
timeout_seconds:
description: 'Kubectl apply wait timeout in seconds for Deployments'
required: true
required: false
type: number
force_restart:
description: 'Force Deployment Rollout Restart'
Expand Down Expand Up @@ -143,6 +143,12 @@ jobs:
echo "vars.HELM_FORCE_UPGRADE_MICROSERVICES_CSV: ${{ vars.HELM_FORCE_UPGRADE_MICROSERVICES_CSV }}"
echo "ENABLE_FORCE_UPGRADE: $ENABLE_FORCE_UPGRADE"

if [[ -z "${TIMEOUT_SECONDS:-}" ]]; then
echo "No timeout specified, using dynamic timeout."
TIMEOUT_SECONDS=$(./$SCRIPTS_FOLDER/get-rollout-dynamic-wait.sh --namespace ${{ inputs.environment }} --deployment $MICROSERVICE_NAME --batch-wait 30)
echo "Dynamic timeout calculated: $TIMEOUT_SECONDS seconds."
fi

TIMEOUT="${TIMEOUT_SECONDS}s"

export PROJECT_DIR=$(pwd)
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ jobs:
uses: ./.github/workflows/deploy-sub.yaml
with:
environment: ${{ inputs.environment }}
timeout_seconds: 300
force_restart: ${{ inputs.force_restart }}

delete_runner:
Expand Down