Skip to content

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented May 7, 2025

Short description

This PR allows users to scroll the Terms of Service webpage all the way to the bottom, ensuring the last "read more" link can be expanded.

Details

Android

Setting ✅
android-.mov
android-.mov
android-2-.mov

iOS

Settings ✅
ios-.mp4
ios-.mp4
ios-2-.mp4

List of changes proposed in this pull request

  • Integrated useFooterActionsMeasurements into TosWebViewComponent to enable full scroll access.

How to test

  1. Navigate to the Terms of Service screen during the first onboarding flow.
  2. Try scrolling to the bottom of the page.
  3. Confirm that the last "read more" link can be expanded correctly.

@shadowsheep1 shadowsheep1 self-assigned this May 7, 2025
@shadowsheep1 shadowsheep1 added Bug 🐞 IO-A&I IO - Autenticazione e Identità labels May 7, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented May 7, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@shadowsheep1
Copy link
Member Author

@dmnplb @Ladirico I'm not fully convinced by this solution. Do you think there might be a cleaner way to fix this bug?

@dmnplb
Copy link
Contributor

dmnplb commented May 7, 2025

@dmnplb @Ladirico I'm not fully convinced by this solution. Do you think there might be a cleaner way to fix this bug?

@shadowsheep1 My recommendation is to use the useFooterActionsMeasurements hook to get the most accurate spacing value. It's also dynamic because it depends on the computed height of the FooterActions block. You can find some examples in the app.

This way you can easily remove the VSpacer components because they're no longer needed.

@shadowsheep1
Copy link
Member Author

@dmnplb @Ladirico I'm not fully convinced by this solution. Do you think there might be a cleaner way to fix this bug?

@shadowsheep1 My recommendation is to use the useFooterActionsMeasurements hook to get the most accurate spacing value. It's also dynamic because it depends on the computed height of the FooterActions block. You can find some examples in the app.

This way you can easily remove the VSpacer components because they're no longer needed.

I'll give it a try. Thank you!

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.69%. Comparing base (e23706c) to head (8a83561).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
.../privacy/shared/components/TosWebviewComponent.tsx 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6958   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files        1646     1646           
  Lines       34346    34351    +5     
  Branches     7798     7854   +56     
=======================================
+ Hits        19128    19131    +3     
+ Misses      15168    15158   -10     
- Partials       50       62   +12     
Files with missing lines Coverage Δ
.../privacy/shared/components/TosWebviewComponent.tsx 46.15% <66.66%> (+3.29%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23706c...8a83561. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shadowsheep1 shadowsheep1 requested review from a team, freddi301 and gispada as code owners May 7, 2025 13:25
Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowsheep1 shadowsheep1 added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit 34e0d49 May 12, 2025
23 checks passed
@shadowsheep1 shadowsheep1 deleted the IOPID-2989 branch May 12, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 IO-A&I IO - Autenticazione e Identità

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants