-
Notifications
You must be signed in to change notification settings - Fork 111
fix(ToS): [IOPID-2989] Fix onboarding ToS scrolling #6958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
@shadowsheep1 My recommendation is to use the This way you can easily remove the |
I'll give it a try. Thank you! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6958 +/- ##
=======================================
Coverage 55.69% 55.69%
=======================================
Files 1646 1646
Lines 34346 34351 +5
Branches 7798 7854 +56
=======================================
+ Hits 19128 19131 +3
+ Misses 15168 15158 -10
- Partials 50 62 +12
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR allows users to scroll the Terms of Service webpage all the way to the bottom, ensuring the last "read more" link can be expanded.
Details
Android
android-.mov
android-.mov
android-2-.mov
iOS
ios-.mp4
ios-.mp4
ios-2-.mp4
List of changes proposed in this pull request
useFooterActionsMeasurements
intoTosWebViewComponent
to enable full scroll access.How to test