Skip to content

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 14, 2025

Short description

This PR enables full support for edge-to-edge navigation on Android.

List of changes proposed in this pull request

  • Enable full support for edge-to-edge navigation by updating MainActivity.kt file
  • Fix splash screen ugly rectangles in both gesture and button navigation modes
  • Remove ugly white rectangle at the top of the BarcodeScanScreen
  • Remove ugly white rectangle at the top of the ServiceDetail screen
  • Update react-native-safe-area-context to the latest version

⚠️ Known issues

  • When gesture navigation mode is on, the inset padding won't be set correctly. This means:
  • There's still a white rectangle at the bottom of the IdentificationModal
  • When the button mode is enabled, the navigation bar will have an opaque black background instead of the light grey background it had before.

Important

These issues appear to be caused by the react-native-safe-area-context package not handling the insets properly:

Preview

Splash screen

Before

Button mode Gesture mode
splash-screen-legacy splash-screen-edge-new

After

Button mode Gesture mode
Screenshot_20250114_123211 Screenshot_20250114_121630

Barcode Scan

Before After
barcode-screen-leg-edge barcode-screen-edge-new

Service Detail

Before After
service-detail-legacy-edge service-detail-edge-new

Related tech docs

How to test

  1. Run the app on Android
  2. Change navigation mode between button mode and gesture mode
  3. Navigate through the app to check that everything is working correctly

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter 💅 Visual tweaks labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

❌ Patch coverage is 38.29787% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.01%. Comparing base (aeab171) to head (4d0e38f).

Files with missing lines Patch % Lines
...preferences/screens/AppearancePreferenceScreen.tsx 20.00% 8 Missing ⚠️
ts/hooks/useAppThemeConfiguration.tsx 0.00% 8 Missing ⚠️
ts/utils/hooks/bottomSheet.tsx 33.33% 8 Missing ⚠️
...entication/login/landing/screens/LandingScreen.tsx 75.00% 2 Missing ⚠️
...endesk/screens/ZendeskAskSeeReportsPermissions.tsx 0.00% 1 Missing ⚠️
ts/navigation/AuthenticatedStackNavigator.tsx 0.00% 1 Missing ⚠️
ts/navigation/NotAuthenticatedStackNavigator.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6602       +/-   ##
===========================================
+ Coverage   47.20%   59.01%   +11.80%     
===========================================
  Files        1798     1817       +19     
  Lines       39174    39334      +160     
  Branches     8904     8963       +59     
===========================================
+ Hits        18492    23211     +4719     
+ Misses      20626    16050     -4576     
- Partials       56       73       +17     
Files with missing lines Coverage Δ
...code/components/BarcodeScanBaseScreenComponent.tsx 72.97% <ø> (-0.37%) ⬇️
ts/features/design-system/core/DSLoaders.tsx 45.45% <ø> (ø)
...res/identification/screens/IdentificationModal.tsx 65.16% <ø> (-0.23%) ⬇️
...features/zendesk/screens/ZendeskAskPermissions.tsx 87.50% <100.00%> (+0.14%) ⬆️
...features/zendesk/screens/ZendeskChooseCategory.tsx 70.96% <100.00%> (+0.96%) ⬆️
...tures/zendesk/screens/ZendeskChooseSubCategory.tsx 68.57% <100.00%> (+0.92%) ⬆️
...tures/zendesk/screens/ZendeskSupportHelpCenter.tsx 71.18% <100.00%> (+1.10%) ⬆️
ts/hooks/useFooterActionsMargin.tsx 100.00% <100.00%> (+12.50%) ⬆️
...endesk/screens/ZendeskAskSeeReportsPermissions.tsx 4.54% <0.00%> (-0.22%) ⬇️
ts/navigation/AuthenticatedStackNavigator.tsx 14.28% <0.00%> (-0.72%) ⬇️
... and 5 more

... and 382 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeab171...4d0e38f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design System New visual language and reduction of previous UI clutter hold 💅 Visual tweaks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Edge to edge - Android 15

3 participants