Skip to content

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Apr 29, 2025

Short description

This PR adds the new canary app icon for both iOS/Android.

List of changes proposed in this pull request

  • Add relative assets

How to test

Launch the canary release workflow

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.47%. Comparing base (4b6226a) to head (bcc2ac2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6930   +/-   ##
=======================================
  Coverage   57.47%   57.47%           
=======================================
  Files        1669     1669           
  Lines       34771    34771           
  Branches     7890     7893    +3     
=======================================
  Hits        19983    19983           
  Misses      14732    14732           
  Partials       56       56           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6226a...bcc2ac2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmnplb dmnplb changed the title chore: [IOPLT-805] Add canary iOS app icon chore: [IOPLT-805] Add canary iOS and Android app icons Apr 29, 2025
@dmnplb dmnplb changed the title chore: [IOPLT-805] Add canary iOS and Android app icons chore: [IOPLT-805] Add iOS and Android app icons for the canary release Apr 29, 2025
@CrisTofani
Copy link
Contributor

/canary

@dmnplb dmnplb marked this pull request as ready for review May 23, 2025 13:52
@dmnplb dmnplb requested review from a team, ChrisMattew, freddi301 and gispada as code owners May 23, 2025 13:52
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested on latest canary release

@dmnplb dmnplb added this pull request to the merge queue May 23, 2025
Merged via the queue into master with commit e21c056 May 23, 2025
37 of 38 checks passed
@dmnplb dmnplb deleted the IOPLT-805-add-canary-ios-app-icon branch May 23, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants