Skip to content

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Jul 1, 2025

Short description

This PR migrates from patch-package to yarn patch. Yarn added the yarn patch command since yarn 2, thus eliminating the need of a third party dependency to patch packages.

List of changes proposed in this pull request

  • Re-apply the existing patches by using yarn patch;
  • Remove the react-native-fingerprint-scanner patch as it's not needed anymore. According to the mentioned issue, pointing to this commit, which is something we already do, is sufficient;
  • Update the postinstall script by removing patch-package;
  • Update the yarn.lock which now has fixed version for the patched packages;
  • Update the patches.md file.

How to test

Run rm -rf node_modules && yarn, check that the patches are properly applied by looking into node_modules and test them as well.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Jul 1, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.59%. Comparing base (e9febc0) to head (7dc80c6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7143   +/-   ##
=======================================
  Coverage   59.59%   59.59%           
=======================================
  Files        1830     1830           
  Lines       39518    39518           
  Branches     9119     9061   -58     
=======================================
  Hits        23552    23552           
- Misses      15885    15897   +12     
+ Partials       81       69   -12     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9febc0...7dc80c6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Patches to be properly applied I think we can safely merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants