-
Notifications
You must be signed in to change notification settings - Fork 109
chore: [IOAPPX-502] Migrate to yarn patch #7143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7143 +/- ##
=======================================
Coverage 59.59% 59.59%
=======================================
Files 1830 1830
Lines 39518 39518
Branches 9119 9061 -58
=======================================
Hits 23552 23552
- Misses 15885 15897 +12
+ Partials 81 69 -12 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…PX-502-migrate-yarn-patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Patches to be properly applied I think we can safely merge this
Short description
This PR migrates from
patch-package
toyarn patch
. Yarn added the yarn patch command since yarn 2, thus eliminating the need of a third party dependency to patch packages.List of changes proposed in this pull request
yarn patch
;react-native-fingerprint-scanner
patch as it's not needed anymore. According to the mentioned issue, pointing to this commit, which is something we already do, is sufficient;postinstall
script by removingpatch-package
;yarn.lock
which now has fixed version for the patched packages;patches.md
file.How to test
Run
rm -rf node_modules && yarn
, check that the patches are properly applied by looking intonode_modules
and test them as well.