-
Notifications
You must be signed in to change notification settings - Fork 109
chore: [IOPLT-1280] Enable title transition in the ForceScrollDownView
component
#7339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: [IOPLT-1280] Enable title transition in the ForceScrollDownView
component
#7339
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7339 +/- ##
==========================================
- Coverage 59.35% 59.35% -0.01%
==========================================
Files 1818 1819 +1
Lines 39100 39106 +6
Branches 8962 8961 -1
==========================================
+ Hits 23209 23211 +2
- Misses 15809 15812 +3
- Partials 82 83 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Android the app is crashing.
I also tried uninstalling and reinstalling it, but the issue persists...
Did I miss something?
Screen.Recording.2025-10-01.at.15.32.05.mov
@LeleDallas No, you're not missing anything. I encountered the same behavior, but it resurfaces once you stress-test the scroll events. We need to refactor the entire |
Important
To properly test the behavior added in this PR, you need to point to the following PR from the
io-app-design-system
library:ForceScrollDownView
with optionalanimatedScrollViewRef
io-app-design-system#493The tests in this PR will keep on failing until the PR is merged and the current DS version is updated.
Short description
This PR adds the support for title transition to
ForceScrollDownView
, by adding a new optionalanimatedScrollViewRef
.List of changes proposed in this pull request
io-app-design-system
versionPreview
force-scroll-down-title-transition-ds.mp4
How to test