Skip to content

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Sep 11, 2025

Important

To properly test the behavior added in this PR, you need to point to the following PR from the io-app-design-system library:

The tests in this PR will keep on failing until the PR is merged and the current DS version is updated.

Short description

This PR adds the support for title transition to ForceScrollDownView, by adding a new optional animatedScrollViewRef.

List of changes proposed in this pull request

  • Add relative screen for testing purposes in the Design System section
  • Update the io-app-design-system version

Preview

force-scroll-down-title-transition-ds.mp4

How to test

  1. Go to the Design System section
  2. Go to the ForceScrollDownView w/ Title transition page

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Sep 11, 2025
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Sep 11, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@dmnplb dmnplb marked this pull request as ready for review September 11, 2025 13:03
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.35%. Comparing base (cca9180) to head (fcc38ba).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...stem/core/DSForceScrollDownViewTitleTransition.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7339      +/-   ##
==========================================
- Coverage   59.35%   59.35%   -0.01%     
==========================================
  Files        1818     1819       +1     
  Lines       39100    39106       +6     
  Branches     8962     8961       -1     
==========================================
+ Hits        23209    23211       +2     
- Misses      15809    15812       +3     
- Partials       82       83       +1     
Files with missing lines Coverage Δ
ts/features/design-system/navigation/navigator.tsx 63.63% <ø> (ø)
ts/features/design-system/navigation/routes.ts 100.00% <ø> (ø)
...stem/core/DSForceScrollDownViewTitleTransition.tsx 33.33% <33.33%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca9180...fcc38ba. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Android the app is crashing.
I also tried uninstalling and reinstalling it, but the issue persists...
Did I miss something?

Screen.Recording.2025-10-01.at.15.32.05.mov

@dmnplb
Copy link
Contributor Author

dmnplb commented Oct 6, 2025

On Android the app is crashing. I also tried uninstalling and reinstalling it, but the issue persists... Did I miss something?

@LeleDallas No, you're not missing anything. I encountered the same behavior, but it resurfaces once you stress-test the scroll events. We need to refactor the entire ForceScrollDownView using reanimated methods only, before adding the title transition included in this PR

@dmnplb dmnplb added the hold label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design System New visual language and reduction of previous UI clutter enhancement hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants