-
Notifications
You must be signed in to change notification settings - Fork 109
feat: [IOCOM-2595,IOCOM-2626] New SEND engagement flow #7412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,384
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
…ing logic to the Send Engagement screen
…nResultScreenContent
Vangaorth
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR integrates the new SEND engagement flow shown after a first app opening
List of changes proposed in this pull request
WhatsNewScreenContent
component and its unit testsSendEngagementOnFirstAppOpenScreen
component and its unit testsSendActivationErrorScreen
component and its unit testspnLoginEngagementReducer
to handle the new screen dismissal statecheckShouldDisplaySendEngagementScreen
sagamaybeHandlePendingBackgroundActions
saga to return aboolean
needed to determine whether the newly added saga should be forkedsetSecurityAdviceReadyToShow
action is now handled by the new SEND engagement flowPN_ROUTES
:Demo
Privacy & ToS links
iOS-send-engagement-privacy-and-tos.MP4
android-send-engagement-privacy-and-tos.mp4
Onboarding
iOS-send-engagement-onboarding.MP4
android-send-engagement-onboarding.mp4
iOS-send-engagement-onboarding-activation-error-and-success.MP4
android-send-engagement-onboarding-activation-error-and-success.mp4
Activation(Error & Success)
iOS-send-engagement-activation-error.mov
android-send-engagement-activation-error.mp4
iOS-send-engagement-activation.MP4
android-send-engagement-activation.mp4
Note
The demos were recorded before the fix to the ToS acceptance copy, specifically, the Privacy Policy link was corrected to use an initial capital letter
How to test
The new SEND engagement screen should be displayed if all of the following conditions are met:
Important
In case of an error during the activation flow, clicking "Close" is not considered an explicit dismissal. Therefore, the engagement screen will be shown again upon the next app launch if the previous conditions are still met
Therefore, to verify that everything works correctly, reproduce the behavior shown in the demo videos and make sure that the screen is not displayed whenever even one of the previously listed conditions is not met.
Tip
To test the error scenario, I used a proxy tool to trigger an error on the
/activation
endpoint